Enhance error handling, logging and tests for PI and Corvus classes#27
Merged
Conversation
- Updated ProtocolError to include expected values in its string representation. - Improved error handling in the query method to raise ProtocolError with detailed context. - Added logging statements in test cases to provide better visibility into the PI class operations and states.
- Added debug logging for command sending and response receiving in the Corvus class. - Updated parameter documentation for the `calibrate` method to clarify its purpose. - Introduced new test cases for the Corvus class to validate connection, position, velocity, acceleration, and movement functionalities, ensuring robust testing for hardware interactions.
Enhance error handling and logging in PI class
This was
linked to
issues
Mar 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging fixes for issues #25 #23