Fatal warning improvements #1948
Conversation
Some "fatal" errors might be expected for some esoteric configurations.
While this is not technically fatal, it's almost certainly not what the user wants.
| @@ -200,6 +200,8 @@ namespace platf { | |||
| if (!VIGEM_SUCCESS(status)) { | |||
| BOOST_LOG(warning) << "Couldn't setup connection to ViGEm for gamepad support ["sv << util::hex(status).to_string_view() << ']'; | |||
|
|
|||
| // Log a special fatal message for this case to show the error in the web UI | |||
| BOOST_LOG(fatal) << "ViGEmBus is not installed or running. You must install ViGEmBus for gamepad support!"sv; | |||
There was a problem hiding this comment.
Thank you! I think the final vigembus version has been very finicky to install.
There was a problem hiding this comment.
Yeah, I've seen issues with it too (especially with those unexpected reboots when upgrading ViGEmBus). I'm planning to put up another PR to avoid installing it if it's already present on the system to hopefully avoid these issues.
There was a problem hiding this comment.
We should probably throw up a warning too, that it's known to unexpectedly reboot during install.
There was a problem hiding this comment.
The reason it's rebooting is that the driver is already installed and in use, so I think it should never reboot if we don't upgrade existing versions.
There was a problem hiding this comment.
That makes sense. Can we detect the installed version and put up a warning in the UI if it's not the latest?
We can get latest release info from https://api.github.com/repos/nefarius/ViGEmBus/releases/latest using the tag_name key for comparison.
Description
This PR has a few changes to improve the UX for "fatal" errors in the web UI.
AV_LOG_FATALlog level down to ourerrorlevel to avoid things like Provided device doesn't support required NVENC features #1849Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.