Skip to content

feat(linux/pipewire): add fallback to node id if connection via object serial fails#5302

Merged
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
Kishi85:pipewire-objectserial-fallback-to-node
Jun 22, 2026
Merged

feat(linux/pipewire): add fallback to node id if connection via object serial fails#5302
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
Kishi85:pipewire-objectserial-fallback-to-node

Conversation

@Kishi85

@Kishi85 Kishi85 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Should the object serial pipewire connection fail try to fall back to the old (deprecated) connection method via node id.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85 Kishi85 changed the title feat(linux/pipewire): add fallback to node id if connection via objec… feat(linux/pipewire): add fallback to node id if connection via object serial fails Jun 19, 2026
@Kishi85 Kishi85 force-pushed the pipewire-objectserial-fallback-to-node branch 10 times, most recently from adece93 to 414dd2a Compare June 20, 2026 10:51
@ReenigneArcher ReenigneArcher added this to the pipewire milestone Jun 22, 2026
@ReenigneArcher ReenigneArcher force-pushed the pipewire-objectserial-fallback-to-node branch from 414dd2a to d4aca06 Compare June 22, 2026 18:29
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.84%. Comparing base (6c34c4f) to head (d4aca06).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/pipewire.cpp 7.14% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5302      +/-   ##
==========================================
- Coverage   17.87%   17.84%   -0.04%     
==========================================
  Files         111      111              
  Lines       24589    24596       +7     
  Branches    10888    10890       +2     
==========================================
- Hits         4396     4388       -8     
- Misses      16817    18608    +1791     
+ Partials     3376     1600    -1776     
Flag Coverage Δ
Archlinux 11.19% <0.00%> (-0.01%) ⬇️
FreeBSD-aarch64 ?
FreeBSD-amd64 13.23% <7.14%> (+<0.01%) ⬆️
Homebrew-ubuntu-24.04 13.23% <0.00%> (-0.02%) ⬇️
Linux-AppImage 12.11% <0.00%> (-0.01%) ⬇️
Windows-AMD64 14.91% <ø> (ø)
Windows-ARM64 13.20% <ø> (+<0.01%) ⬆️
macOS-arm64 19.13% <ø> (ø)
macOS-x86_64 18.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/pipewire.cpp 0.16% <7.14%> (+0.16%) ⬆️

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c34c4f...d4aca06. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 4e6e137 into LizardByte:master Jun 22, 2026
106 of 110 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants