-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for global prep commands #977
Add support for global prep commands #977
Conversation
Your PR was set to |
cd03c07
to
288fcc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.
The latest changes look really good to me, although granted I am not fluent in C++. Just from an object oriented perspective, it looks good to me. I think all we really need now is documentation updates and we can merge it into nightly from there. |
@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens. |
Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.
I like the idea of using that though, can probably move the resolutions
and fps
options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.
Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.
Edit 2: Apparently there's no libboost-json-dev
library for debian distros. Do we need to install something additional?
Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.
For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json. |
PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON. |
7658996
to
8d8593c
Compare
8d8593c
to
b712970
Compare
61dc8eb
to
249592a
Compare
Description
Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.
Screenshot
Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed
NA
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.