Skip to content

Conversation

@encelo
Copy link
Contributor

@encelo encelo commented Dec 4, 2024

I have updated the nCine submodule commit to point to the latest one where I have removed the trailing commas from config.json and .luarc.json.

Update: I have rebased this branch on top of the latest C.I. fixes (2).

@encelo
Copy link
Contributor Author

encelo commented Dec 4, 2024

It's still failing. 😢

@carsakiller carsakiller force-pushed the update-ncine branch 11 times, most recently from 9ddbd18 to 4402870 Compare December 4, 2024 02:15
@carsakiller
Copy link
Collaborator

Whew! It works! Hopefully this is the last time I have to mess with the workflow file for a long, long time 😆. Thanks for your patience!

@carsakiller carsakiller added the Addon Update An update for an existing addon label Dec 4, 2024
@carsakiller carsakiller merged commit ee46bae into LuaLS:main Dec 4, 2024
@carsakiller carsakiller mentioned this pull request Dec 4, 2024
@encelo encelo deleted the update-ncine branch December 5, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Addon Update An update for an existing addon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants