Skip to content

Refactor get_config function to improve host handling and logging#207

Merged
grallewellyn merged 3 commits intomainfrom
fix/refactor-environment-getconfig
Feb 26, 2026
Merged

Refactor get_config function to improve host handling and logging#207
grallewellyn merged 3 commits intomainfrom
fix/refactor-environment-getconfig

Conversation

@bsatoriu
Copy link
Collaborator

No description provided.

@grallewellyn
Copy link
Member

Can we make ops the default host in this PR too?

@grallewellyn
Copy link
Member

I made ADE OPS the default host, just merge if you approve

grallewellyn
grallewellyn previously approved these changes Feb 26, 2026
Copy link
Member

@grallewellyn grallewellyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this

@bsatoriu
Copy link
Collaborator Author

Can we make ops the default host in this PR too?

I'm not sure what the implications would be but I don't have any objections. Maybe we make it a separate PR?

@grallewellyn
Copy link
Member

Sure, I reverted the changes

@sonarqubecloud
Copy link

@grallewellyn grallewellyn self-requested a review February 26, 2026 17:02
@grallewellyn grallewellyn merged commit e53aa2e into main Feb 26, 2026
2 of 3 checks passed
@grallewellyn grallewellyn deleted the fix/refactor-environment-getconfig branch February 26, 2026 17:02
@grallewellyn grallewellyn mentioned this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants