Skip to content

Refactor get_config function to improve host handling and logging #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grallewellyn merged 3 commits into from
Feb 26, 2026
Merged

Refactor get_config function to improve host handling and logging #207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c751d0
Refactor get_config function to improve host handling and logging
Feb 26, 2026
ae6b6f0
set ops to default host
grallewellyn Feb 26, 2026
969e3fe
reverted changes
grallewellyn Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions api/endpoints/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging
from flask_restx import Resource
from flask import request
from flask import request, current_app
from api.restplus import api
from urllib.parse import urlsplit
from api import settings
Expand Down Expand Up @@ -66,16 +66,23 @@ def get_config_from_api(api_host):

def get_config(host, server_type):
try:
ROOT = os.path.dirname(os.path.abspath(__file__))
ROOT = os.path.dirname(os.path.abspath(__file__))
with open(os.path.join(ROOT, "environments.json")) as f:
data = json.load(f)
except FileNotFoundError:
msg = "environments.json file could not be found"
logging.exception(msg)
raise FileNotFoundError(msg)

base_url = "{0.netloc}".format(urlsplit(urllib.parse.unquote(host)))
unquoted_host = urllib.parse.unquote(host)
if "://" not in unquoted_host:
unquoted_host = "https://" + unquoted_host
base_url = "{0.netloc}".format(urlsplit(unquoted_host))

match = next((x for x in data if base_url == x[server_type]), None)

maap_config = next((x for x in data if x['default_host'] == True), None) if match is None else match
if match is None:
current_app.logger.debug("No environment.get_config() host match found, falling back to default_host config: %s", maap_config)

return maap_config
Loading