- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.4k
 
build(react-compiler) - 05: Fix CI errors from react-compiler lint fixes #37396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jongsun/build/251030-fix-react-compiler-rule-violations
Are you sure you want to change the base?
Conversation
| 
           CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.  | 
    
          
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +5 -1)
 ✅ @MetaMask/confirmations (8 files, +34 -21)
 🫰 @MetaMask/core-platform (5 files, +9 -6)
 🔔 @MetaMask/notifications (1 files, +3 -1)
 🔐 @MetaMask/web3auth (1 files, +2 -0)
  | 
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [76631aa]
 UI Startup Metrics (1262 ± 75 ms)
  | 
    
76631aa    to
    6b148d8      
    Compare
  
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [6b148d8]
 UI Startup Metrics (1305 ± 96 ms)
  | 
    
6b148d8    to
    afd5d3b      
    Compare
  
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [afd5d3b]
 UI Startup Metrics (1226 ± 96 ms)
  | 
    
d49dbfc    to
    99ebeb6      
    Compare
  
    fd2c95e    to
    579e34c      
    Compare
  
    99ebeb6    to
    09e75b6      
    Compare
  
    579e34c    to
    20d1a20      
    Compare
  
    aad9d54    to
    93d50bd      
    Compare
  
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [93d50bd]
 UI Startup Metrics (1281 ± 103 ms)
  | 
    
93d50bd    to
    4f3bc0b      
    Compare
  
    aac982f    to
    e68f0e4      
    Compare
  
    4f3bc0b    to
    4ef9f2b      
    Compare
  
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [4ef9f2b]
 UI Startup Metrics (1291 ± 100 ms)
  | 
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [a4b4c09]
 UI Startup Metrics (1270 ± 95 ms)
  | 
    
          📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results
 Results generated automatically by MetaMask CI  | 
    
          Builds ready [5770d7c]
 UI Startup Metrics (1313 ± 90 ms)
  | 
    
fbd1280    to
    780e380      
    Compare
  
    bda455b    to
    f866399      
    Compare
  
    780e380    to
    655cd2c      
    Compare
  
    f866399    to
    63b9cd1      
    Compare
  
    655cd2c    to
    075cca7      
    Compare
  
    
          Builds ready [075cca7]
 UI Startup Metrics (1311 ± 102 ms)
 📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results 
  | 
    
          Builds ready [36d12d5]
 UI Startup Metrics (1297 ± 99 ms)
 📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results 
  | 
    
63b9cd1    to
    0d2d321      
    Compare
  
    e515461    to
    764cfdf      
    Compare
  
    
          Builds ready [764cfdf]
 UI Startup Metrics (1285 ± 100 ms)
 📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results 
  | 
    
0d2d321    to
    7dc999b      
    Compare
  
    764cfdf    to
    5c5b9a2      
    Compare
  
    
          Builds ready [5c5b9a2]
 UI Startup Metrics (1279 ± 95 ms)
 📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results 
  | 
    
7dc999b    to
    d8828a1      
    Compare
  
    5c5b9a2    to
    f8eee97      
    Compare
  
    
          Builds ready [f8eee97]
 UI Startup Metrics (1272 ± 101 ms)
 📊 Page Load Benchmark ResultsCurrent Commit:  📄 Localhost MetaMask Test DappSamples: 100 Summary
 📈 Detailed Results 
  | 
    
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist