Skip to content

fix(15619): permissions summary page shows only network permissions #15623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented May 23, 2025

Description

Issue: When a dapp is requesting permissions for a network that hasn't been given yet, the flow enters what looks to be a broken state to the user. The functionality works but the user experience is degraded.

Solution: Give the component options to opt out of the tab view and only show the account permissions or the network permissions. So when the user is prompted to give permissions to a network, they are only shown the network permissions view

Related issues

Fixes: #15619

Manual testing steps

  1. Goto https://pancakeswap.finance/
  2. Enable all networks except 1 network (or several doesn't matter)
  3. Click update
  4. In pancake swap click on a network that doesn't have permissions
  5. The view with the broken state will apepar

Screenshots/Recordings

Before After
before after

New Props

When the new propsshowAccountsOnly is true

When the new propsshowPermissionsOnly is true

When both are true. Accounts are 0 because there aren't any account props passed. This is just an example of what it would look like

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the Run Smoke E2E Requires smoke E2E testing label May 23, 2025
Copy link
Contributor

github-actions bot commented May 23, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f3e1f0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/19484bc4-f379-4b8a-bedb-5997603e5c96

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added the QA in Progress QA has started on the feature. label May 23, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E Requires smoke E2E testing QA in Progress QA has started on the feature. labels May 23, 2025
Copy link
Contributor

github-actions bot commented May 23, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ed8e516
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dd714191-5185-4136-8482-653c2ee34c27

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

EtherWizard33
EtherWizard33 previously approved these changes May 26, 2025
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very readable code change, thanks for that.
Approving

I have recorded a loom about the button icon for network switching, will share in slack

…15619-broken-ux-asking-networks-permissions-view
…vatar no longer shows when dapp is requesting network permissions
@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 4ee8339
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0ded34-0189-469d-935a-de2a351ca006

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
Copy link
Contributor

github-actions bot commented May 27, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c4a00fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/680a27d7-a988-4ff7-a2c4-dc08ae30b2b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

EtherWizard33
EtherWizard33 previously approved these changes May 27, 2025
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

adonesky1
adonesky1 previously approved these changes May 27, 2025
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward dismissed stale reviews from adonesky1 and EtherWizard33 via 0c64bb8 May 27, 2025 19:53
@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 0c64bb8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/49c59c9e-024f-4c2b-af39-3993b95d84cf

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
Copy link
Contributor

github-actions bot commented May 27, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3ce61b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ffaa0aa-0ea8-4d62-b336-e0eee748d9cb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.58%. Comparing base (c09f9e1) to head (3ce61b2).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...UI/PermissionsSummary/PermissionsSummary.styles.ts 50.00% 0 Missing and 2 partials ⚠️
...nents/UI/PermissionsSummary/PermissionsSummary.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15623      +/-   ##
==========================================
+ Coverage   69.49%   69.58%   +0.08%     
==========================================
  Files        2464     2474      +10     
  Lines       52780    53020     +240     
  Branches     7996     8062      +66     
==========================================
+ Hits        36680    36894     +214     
- Misses      13750    13756       +6     
- Partials     2350     2370      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit c6e57a9 May 27, 2025
56 of 59 checks passed
@vinnyhoward vinnyhoward deleted the feat-15619-broken-ux-asking-networks-permissions-view branch May 27, 2025 23:07
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Requires smoke E2E testing team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken UX when dapp asks for network permissions for new flow
6 participants