-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(15619): permissions summary page shows only network permissions #15623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(15619): permissions summary page shows only network permissions #15623
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
app/components/UI/PermissionsSummary/PermissionsSummary.styles.ts
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very readable code change, thanks for that.
Approving
I have recorded a loom about the button icon for network switching, will share in slack
…15619-broken-ux-asking-networks-permissions-view
…vatar no longer shows when dapp is requesting network permissions
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…15619-broken-ux-asking-networks-permissions-view
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15623 +/- ##
==========================================
+ Coverage 69.49% 69.58% +0.08%
==========================================
Files 2464 2474 +10
Lines 52780 53020 +240
Branches 7996 8062 +66
==========================================
+ Hits 36680 36894 +214
- Misses 13750 13756 +6
- Partials 2350 2370 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
Issue: When a dapp is requesting permissions for a network that hasn't been given yet, the flow enters what looks to be a broken state to the user. The functionality works but the user experience is degraded.
Solution: Give the component options to opt out of the tab view and only show the account permissions or the network permissions. So when the user is prompted to give permissions to a network, they are only shown the network permissions view
Related issues
Fixes: #15619
Manual testing steps
Screenshots/Recordings
New Props
When the new props

showAccountsOnly
istrue
When the new props

showPermissionsOnly
istrue
When both are

true
. Accounts are 0 because there aren't any account props passed. This is just an example of what it would look likeBefore
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist