Skip to content

Conversation

@juanmigdr
Copy link
Member

@juanmigdr juanmigdr commented Oct 24, 2025

Description

The network selector in the settings view is very outdated and inconsistent with the new Bip-44 UI. This is causing:

  • New bugs raised
  • Double Developer effort when dealing with networks
  • Inconsistencies

Therefore, after consulting with @Tlees-MMI and @alfeng6 we have come to the conclussion of fully removing it from the settings view. From now on if users want to do anything related to network management they can use the network selector from the Wallet Screen. Here is part of the discussion:

image

Changelog

CHANGELOG entry: removal of network selector in settings

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Screen.Recording.2025-10-29.at.12.08.07.mov

After

Screen.Recording.2025-10-29.at.11.01.32.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the deprecated Networks settings screen and entry, shifting network management to the wallet network switcher and updating navigation, unit tests, and e2e flows accordingly.

  • Settings:
    • Remove Networks drawer item and related handler from Views/Settings.
  • Navigation:
    • Remove NetworksSettings screen from MainNavigator.
  • NetworksSettings Removal:
    • Delete Views/Settings/NetworksSettings component, unit tests, and snapshots.
  • Tests/E2E:
    • Update Settings snapshot and unit tests to exclude networks-settings.
    • Remove NETWORKS selector and page object methods.
    • Refactor e2e flows to manage networks via wallet network switcher (WalletView/NetworkListModal) instead of Settings (e.g., add/delete networks, permission cleanup, localhost helper).

Written by Cursor Bugbot for commit d94fbf5. This will update automatically on new commits. Configure here.

@sonarqubecloud
Copy link

@juanmigdr juanmigdr marked this pull request as ready for review October 29, 2025 10:59
@juanmigdr juanmigdr requested review from a team as code owners October 29, 2025 10:59
@juanmigdr juanmigdr enabled auto-merge October 29, 2025 11:00
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Missing Navigation to NetworkView

The test "should add BSC network" calls NetworkView.tapAddNetworkButton() without first navigating to the NetworkView. The previous test "should go to settings then networks" which provided this navigation was removed, but this test was not updated accordingly. The test will fail because NetworkView is not visible. It should navigate to the network view first using await WalletView.tapNetworksButtonOnNavBar(); before attempting to interact with NetworkView elements, similar to how addLocalhostNetwork() was updated in viewHelper.ts.

e2e/specs/quarantine/deeplinks.failing.ts#L80-L89

it('should add BSC network', async () => {
// Tap on Add Network button
await TestHelpers.delay(3000);
await NetworkView.tapAddNetworkButton();
await Assertions.expectElementToBeVisible(NetworkView.networkContainer);
await NetworkView.tapNetworkByName(
PopularNetworksList.BNB.providerConfig.nickname,
);

Fix in Cursor Fix in Web


await CommonView.tapOKAlertButton();
});

it('should go to settings then networks', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen has been removed so no deep-linking for it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Great job updating quarantined tests! Reduces confusion once this comes out of quarantine.

@juanmigdr juanmigdr added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit b3791df Oct 29, 2025
93 checks passed
@juanmigdr juanmigdr deleted the chore/remove-deprecated-network-selector-from-settings branch October 29, 2025 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-L team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants