-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: remove deprecated network selector from settings #21614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated network selector from settings #21614
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test Missing Navigation to NetworkView
The test "should add BSC network" calls NetworkView.tapAddNetworkButton() without first navigating to the NetworkView. The previous test "should go to settings then networks" which provided this navigation was removed, but this test was not updated accordingly. The test will fail because NetworkView is not visible. It should navigate to the network view first using await WalletView.tapNetworksButtonOnNavBar(); before attempting to interact with NetworkView elements, similar to how addLocalhostNetwork() was updated in viewHelper.ts.
e2e/specs/quarantine/deeplinks.failing.ts#L80-L89
metamask-mobile/e2e/specs/quarantine/deeplinks.failing.ts
Lines 80 to 89 in d94fbf5
| it('should add BSC network', async () => { | |
| // Tap on Add Network button | |
| await TestHelpers.delay(3000); | |
| await NetworkView.tapAddNetworkButton(); | |
| await Assertions.expectElementToBeVisible(NetworkView.networkContainer); | |
| await NetworkView.tapNetworkByName( | |
| PopularNetworksList.BNB.providerConfig.nickname, | |
| ); |
| await CommonView.tapOKAlertButton(); | ||
| }); | ||
|
|
||
| it('should go to settings then networks', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen has been removed so no deep-linking for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Great job updating quarantined tests! Reduces confusion once this comes out of quarantine.



Description
The network selector in the settings view is very outdated and inconsistent with the new Bip-44 UI. This is causing:
Therefore, after consulting with @Tlees-MMI and @alfeng6 we have come to the conclussion of fully removing it from the settings view. From now on if users want to do anything related to network management they can use the network selector from the Wallet Screen. Here is part of the discussion:
Changelog
CHANGELOG entry: removal of network selector in settings
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-10-29.at.12.08.07.mov
After
Screen.Recording.2025-10-29.at.11.01.32.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes the deprecated Networks settings screen and entry, shifting network management to the wallet network switcher and updating navigation, unit tests, and e2e flows accordingly.
Networksdrawer item and related handler fromViews/Settings.NetworksSettingsscreen fromMainNavigator.Views/Settings/NetworksSettingscomponent, unit tests, and snapshots.Settingssnapshot and unit tests to excludenetworks-settings.NETWORKSselector and page object methods.WalletView/NetworkListModal) instead of Settings (e.g., add/delete networks, permission cleanup, localhost helper).Written by Cursor Bugbot for commit d94fbf5. This will update automatically on new commits. Configure here.