Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

BDK Syncing improvements #1029

Closed
wants to merge 1 commit into from
Closed

BDK Syncing improvements #1029

wants to merge 1 commit into from

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Feb 15, 2024

No description provided.

@benthecarman benthecarman added bug Something isn't working BDK labels Feb 15, 2024
@AnthonyRonning
Copy link
Contributor

this seems a little unsafe to me as we aren't getting the status of these txs anymore

Is this when the transaction confirms? If there's any problems, a resync should fix it, right?

@benthecarman
Copy link
Collaborator Author

Is this when the transaction confirms? If there's any problems, a resync should fix it, right?

Well when we sync we only check unused spks, but since this address would have a transaction it would be used and we'd stop checking it

@AnthonyRonning
Copy link
Contributor

Made no difference, still 117 requests on my mainnet wallet.

@AnthonyRonning
Copy link
Contributor

Feel free to test this on mainnet too @benthecarman

@benthecarman benthecarman changed the title Don't sync unconfirmed txids when syncing bdk BDK Syncing improvements Feb 15, 2024
@benthecarman benthecarman removed the bug Something isn't working label Feb 15, 2024
@AnthonyRonning
Copy link
Contributor

wasn't needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants