change default logging parameters to be clearcut rather than reduced-impact#1359
Merged
glemieux merged 4 commits intoNGEET:mainfrom May 20, 2025
Merged
change default logging parameters to be clearcut rather than reduced-impact#1359glemieux merged 4 commits intoNGEET:mainfrom
glemieux merged 4 commits intoNGEET:mainfrom
Conversation
…uced-impact logging
glemieux
added
inputs: parameter file
Contributor
|
FYI @sshu88 would you take a look at this when you have a moment, please? |
Contributor
These revisions make sense for global default simulation. Thanks for working on it. |
glemieux
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
glemieux
moved this from Under Review
to Final Testing
in FATES Pull Request Planning and Status
mpaiao
approved these changes
Apr 7, 2025
Contributor
mpaiao
left a comment
mpaiao
left a comment
There was a problem hiding this comment.
Hi @ckoven, I just checked the parameter updates, and they look good to me for making the clearcut the default.
In principle, logging characteristics could vary spatially, so these parameters could eventually be migrated to the land use files. This is very low priority though, I am not aware of any such dataset.
4 tasks
this commit doesn't include the base_file refenced in the patch as that will become available via NGEET#1358 when these are merged together
The workflow for merging these should run NGEET#1358 prior to this patch so this patch should use the default to make sure to include NGEET#1358 changes
This was referenced May 8, 2025
glemieux
moved this from Final Testing
to Stuck
in FATES Pull Request Planning and Status
Contributor
|
See #1406 (comment) for discussion of test results. This PR will be automerged when #1406 will be integrated into |
github-project-automation
bot
moved this from Hold
to Ready to Integrate
in FATES Pull Request Planning and Status
samsrabin
added a commit
to samsrabin/fates
that referenced
this pull request
Jun 10, 2025
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
samsrabin
added a commit
to samsrabin/fates
that referenced
this pull request
Jun 23, 2025
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
These changes to the parameter file make harvest be clear-cut rather than reduced-impact logging. The argument is that that is more consistent with how the global land use datasets are treating logging. Ideally it would be better to have regionally- (and temporally-) differentiated logging parameters, but for initial global simulations, this endmember assumption is probably the place to start from.
Collaborators:
Expectation of Answer Changes:
This will change answers in all configurations that include logging.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: