#186 - Cannot collapse Tasks Filters as Guest user in Local Deployment #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elookpotts-nvidia
approved these changes
Dec 19, 2025
RyaliNvidia
approved these changes
Dec 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem repro'd if there were no users in the system, such as in this case after a clean local deployment.
NOTE: The infinite loop seen in this bug is triggered because updateUrl is in the dependency array of the useEffect that calls validateFilters in tasks/page.tsx. updateUrl should have been a useCallback - a problem that has already been fixed in main, as part of a different improvement. So, this issue did not repro in main.
All the same, this fix is still warranted as the APIs all work with all_users=false and an empty user array - returning tasks/workflows/datasets for the current user in such case. So, validating that users are selected is not necessary since the APIs support that use-case.
FYI: Users become first-class citizens after submitting a workflow.
Issue #168
Checklist