Skip to content

#186 - Cannot collapse Tasks Filters as Guest user in Local Deployment #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patclarknvidia merged 2 commits into from
Dec 20, 2025
Merged

#186 - Cannot collapse Tasks Filters as Guest user in Local Deployment #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f38b47
Cannot collapse Tasks Filters as Guest user in Local Deployment
patclarknvidia Dec 19, 2025
a16df6b
Fix lint
patclarknvidia Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions ui/src/app/datasets/components/Datasets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,8 @@ export default function Datasets() {
}, [isSelectAllUsersChecked, userFilter, username]);

const validateFilters = useCallback(
({
userType,
selectedUsers,
selectedBuckets,
dateRange,
createdAfter,
createdBefore,
}: DatasetsFilterDataProps): string[] => {
({ selectedBuckets, dateRange, createdAfter, createdBefore }: DatasetsFilterDataProps): string[] => {
const errors: string[] = [];

if (selectedUsers.length === 0 && userType !== UserFilterType.ALL) {
errors.push("Please select at least one user");
}
if (selectedBuckets.length === 0) {
errors.push("Please select at least one bucket");
}
Expand Down
5 changes: 0 additions & 5 deletions ui/src/app/tasks/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ export default function Tasks() {

const validateFilters = useCallback(
({
selectedUsers,
userType,
isSelectAllPoolsChecked,
selectedPools,
dateRange,
Expand All @@ -167,9 +165,6 @@ export default function Tasks() {
isSelectAllNodesChecked,
}: TasksFiltersDataProps): string[] => {
const errors: string[] = [];
if (selectedUsers.length === 0 && userType !== UserFilterType.ALL) {
errors.push("Please select at least one user");
}
if (!isSelectAllPoolsChecked && selectedPools.length === 0) {
errors.push("Please select at least one pool");
}
Expand Down
5 changes: 0 additions & 5 deletions ui/src/app/taskssummary/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ export default function TasksSummary() {

const validateFilters = useCallback(
({
selectedUsers,
userType,
isSelectAllPoolsChecked,
selectedPools,
dateRange,
Expand All @@ -161,9 +159,6 @@ export default function TasksSummary() {
isSelectAllNodesChecked,
}: TasksFiltersDataProps): string[] => {
const errors: string[] = [];
if (selectedUsers.length === 0 && userType !== UserFilterType.ALL) {
errors.push("Please select at least one user");
}
if (!isSelectAllPoolsChecked && selectedPools.length === 0) {
errors.push("Please select at least one pool");
}
Expand Down
5 changes: 0 additions & 5 deletions ui/src/app/workflows/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ export default function Workflows() {

const validateFilters = useCallback(
({
selectedUsers,
userType,
isSelectAllPoolsChecked,
selectedPools,
dateRange,
Expand All @@ -122,9 +120,6 @@ export default function Workflows() {
statuses,
}: WorkflowsFiltersDataProps): string[] => {
const errors: string[] = [];
if (selectedUsers.length === 0 && userType !== UserFilterType.ALL) {
errors.push("Please select at least one user");
}
if (!isSelectAllPoolsChecked && selectedPools.length === 0) {
errors.push("Please select at least one pool");
}
Expand Down