Skip to content

Fix #5603 - Deprecate method with typo and replace with proper spelling (RoofVegetation::setInitialVolumetricMoistureConent)#5607

Open
jmarrec wants to merge 1 commit intodevelopfrom
5603-TypoRoofVegetation
Open

Fix #5603 - Deprecate method with typo and replace with proper spelling (RoofVegetation::setInitialVolumetricMoistureConent)#5607
jmarrec wants to merge 1 commit intodevelopfrom
5603-TypoRoofVegetation

Conversation

@jmarrec
Copy link
Copy Markdown
Collaborator

@jmarrec jmarrec commented Apr 7, 2026

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Apr 7, 2026
@jmarrec jmarrec added component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 4151
Passed 4142
Failed 9
Errors 0
Skipped 0
Success Rate 99.8%
Generated 2026-04-07 14:43:48 UTC

⚠️ Minor Issues Detected

🔍 Failed Tests (9 failures)

Linux-c++ (9 failures)

OpenStudioCLI.test_measure_manager.OpenStudioCLI.test_measure_manager (run1)

Error Message:

Failed

Full Details:

No details available
BCLFixture.RemoteBCLTest.BCLFixture.RemoteBCLTest (run3)

Error Message:

Failed

Full Details:

No details available
BCLFixture.RemoteBCLTest2.BCLFixture.RemoteBCLTest2 (run3)

Error Message:

Failed

Full Details:

No details available
BCLFixture.GetComponentByUID.BCLFixture.GetComponentByUID (run3)

Error Message:

Failed

Full Details:

No details available
BCLFixture.RemoteBCLMetaSearchTest.BCLFixture.RemoteBCLMetaSearchTest (run3)

Error Message:

Failed

Full Details:

No details available
BCLFixture.RemoteBCL_EncodingURI.BCLFixture.RemoteBCL_EncodingURI (run3)

Error Message:

Failed

Full Details:

No details available
BCLFixture.RemoteBCL_BCLSearchResult.BCLFixture.RemoteBCL_BCLSearchResult (run3)

Error Message:

Failed

Full Details:

No details available
OpenStudioCLI.test_measure_manager.OpenStudioCLI.test_measure_manager (run3)

Error Message:

Failed

Full Details:

No details available
OpenStudioCLI.Classic.test_measure_manager.OpenStudioCLI.Classic.test_measure_manager (run3)

Error Message:

Failed

Full Details:

No details available

📊 Test Run Information

Run XML File Status
run1 results.xml ✅ Found
run3 results.xml ✅ Found
run2 results.xml ✅ Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in Python API: 'setInitialVolumetricMoistureConent' in RoofVegetation class

1 participant