Skip to content

Fix #5603 - Deprecate method with typo and replace with proper spelling (RoofVegetation::setInitialVolumetricMoistureConent) #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmarrec wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −2
Open

Fix #5603 - Deprecate method with typo and replace with proper spelling (RoofVegetation::setInitialVolumetricMoistureConent) #5607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/model/RoofVegetation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../utilities/units/Unit.hpp"

#include "../utilities/core/Assert.hpp"
#include "../utilities/core/DeprecatedHelpers.hpp"

namespace openstudio {
namespace model {
Expand Down Expand Up @@ -883,7 +884,7 @@ namespace model {
return getImpl<detail::RoofVegetation_Impl>()->setResidualVolumetricMoistureContent(value);
}

bool RoofVegetation::setInitialVolumetricMoistureConent(double value) {
bool RoofVegetation::setInitialVolumetricMoistureContent(double value) {
return getImpl<detail::RoofVegetation_Impl>()->setInitialVolumetricMoistureContent(value);
}

Expand Down Expand Up @@ -993,6 +994,12 @@ namespace model {

/// @cond
RoofVegetation::RoofVegetation(std::shared_ptr<detail::RoofVegetation_Impl> impl) : OpaqueMaterial(std::move(impl)) {}

// DEPRECATED
bool RoofVegetation::setInitialVolumetricMoistureConent(double value) {
DEPRECATED_AT_MSG(3, 11, 0, "Use setInitialVolumetricMoistureContent instead.");
return getImpl<detail::RoofVegetation_Impl>()->setInitialVolumetricMoistureContent(value);
}
/// @endcond

} // namespace model
Expand Down
4 changes: 3 additions & 1 deletion src/model/RoofVegetation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

#include "ModelAPI.hpp"
#include "OpaqueMaterial.hpp"
#include "../utilities/core/Deprecated.hpp"

namespace openstudio {

Expand Down Expand Up @@ -158,7 +159,8 @@ namespace model {

bool setResidualVolumetricMoistureContent(double value);

bool setInitialVolumetricMoistureConent(double value);
OS_DEPRECATED(3, 11, 0) bool setInitialVolumetricMoistureConent(double value);
bool setInitialVolumetricMoistureContent(double value);

bool setMoistureDiffusionCalculationMethod(const std::string& value);

Expand Down
Loading