nixos/jellystat: init module - #552946
Draft
Mistyttm wants to merge 2 commits into
Draft
Conversation
nixpkgs-ci
Bot
added
8.has: package (new)
Mistyttm
force-pushed
the
add-jellystat-module
branch
from
August 16, 2026 05:46
9a19497 to
c807bd6
Compare
Contributor
Author
|
That's a bunch of fixes and the module documentation done |
nixpkgs-ci
Bot
added
8.has: changelog
Comment on lines
+43
to
+47
| ${lib.concatStringsSep "\n" ( | ||
| lib.mapAttrsToList (name: file: '' | ||
| export ${name}="$(${pkgs.coreutils}/bin/cat ${lib.escapeShellArg file})" | ||
| '') secretFiles | ||
| )} |
Member
There was a problem hiding this comment.
Why not use EnvironmentFile instead?
|
|
||
| networking.firewall.allowedTCPPorts = lib.mkIf cfg.openFirewall [ cfg.settings.port ]; | ||
|
|
||
| systemd.tmpfiles.rules = [ |
Member
There was a problem hiding this comment.
Please use tmpfiles.settings instead.
Comment on lines
+151
to
+156
| package = lib.mkOption { | ||
| type = lib.types.package; | ||
| default = pkgs.postgresql; | ||
| defaultText = lib.literalExpression "pkgs.postgresql"; | ||
| description = "PostgreSQL package to use for the local Jellystat database."; | ||
| }; |
Member
There was a problem hiding this comment.
Please leave this up to the postgres module
|
|
||
| services.postgresql = lib.mkIf cfg.settings.database.enable { | ||
| enable = true; | ||
| package = cfg.settings.database.package; |
Member
There was a problem hiding this comment.
Suggested change
| package = cfg.settings.database.package; |
| ensureClauses.createdb = true; | ||
| } | ||
| ]; | ||
| authentication = '' |
Member
There was a problem hiding this comment.
I would love to leave the default here
Contributor
Author
|
Thanks for the review, I'll get those fixed asap I knew I was over thinking the postgres section, I keep doing that when I make a module for a package that uses postgres. Just doesn't seem to ever make sense to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module for jellystat, I have a couple more tweaks to make, but I wanted a draft PR to track it with the package addition
blocked by #552923
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.