Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add chain id to error message #514

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

fvictorio
Copy link
Member

This error is a bit better if it includes the remote chain id, because then adding it to the default hardfork histories (as done in NomicFoundation/hardhat#5394) will be easier.

@fvictorio fvictorio requested review from agostbiro and Wodann June 14, 2024 15:19
Copy link

changeset-bot bot commented Jun 14, 2024

⚠️ No Changeset found

Latest commit: 3d6ea1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio fvictorio temporarily deployed to github-action-benchmark June 14, 2024 15:19 — with GitHub Actions Inactive
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. There are some Hardhat integration tests that check the error message -- those might need to be udpated. And a changeset is needed.

@fvictorio
Copy link
Member Author

I generally don't add changesets for very minor changes in error messages, even if it's technically a user-facing change, because I don't think they are worth the noise in the release notes. But if you'd rather err on the side of adding one, I can do it, no problem.

Good point about the tests, I'll check.

@fvictorio
Copy link
Member Author

Based on both grepping and the fact that they pass, I don't think we need to update any tests.

@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Jun 18, 2024
@fvictorio fvictorio added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 28cd352 Jun 18, 2024
36 of 37 checks passed
@fvictorio fvictorio deleted the add-chain-id-to-error-message branch June 18, 2024 06:59
@Wodann Wodann added this to the EDR v0.4.1 milestone Jul 11, 2024
@Wodann Wodann linked an issue Jul 11, 2024 that may be closed by this pull request
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include error details from EDR
3 participants