Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add chain id to error message #514

Merged
merged 1 commit into from
Jun 18, 2024
Merged

improvement: add chain id to error message #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/edr_evm/src/blockchain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,14 @@ pub enum BlockchainError {
expected: B256,
},
/// Missing hardfork activation history
#[error("No known hardfork for execution on historical block {block_number} (relative to fork block number {fork_block_number}). The node was not configured with a hardfork activation history.")]
#[error("No known hardfork for execution on historical block {block_number} (relative to fork block number {fork_block_number}) in chain with id {chain_id}. The node was not configured with a hardfork activation history.")]
MissingHardforkActivations {
/// Block number
block_number: u64,
/// Fork block number
fork_block_number: u64,
/// Chain id
chain_id: u64,
},
/// Missing withdrawals for post-Shanghai blockchain
#[error("Missing withdrawals for post-Shanghai blockchain")]
Expand Down
1 change: 1 addition & 0 deletions crates/edr_evm/src/blockchain/forked.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ impl Blockchain for ForkedBlockchain {
Err(BlockchainError::MissingHardforkActivations {
block_number,
fork_block_number: self.fork_block_number,
chain_id: self.remote_chain_id,
})
}
})
Expand Down
Loading