Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't build edr_napi before testing in CI #4888

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Feb 19, 2024

After we build NAPI binaries in the CI, we test them on their respective platforms using the node Docker image.

In #4831 we made a change to make pnpm test trigger pnpm build. This caused testing to fail in node Docker containers as the Rust toolchain is not available there.

This PR fixes this by adding a testNoBuild command that is executed in the CI.

Closes NomicFoundation/edr#293

@agostbiro agostbiro self-assigned this Feb 19, 2024
Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: 507b5b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 4:01pm

@agostbiro agostbiro merged commit 6bee060 into main Feb 19, 2024
38 of 46 checks passed
@agostbiro agostbiro deleted the edr/ci/no-build-before-testing-ci branch February 19, 2024 16:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:edr no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the "EDR NPM release" workflow
4 participants