Type-safe HardhatError
#5283
Type-safe HardhatError
#5283
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
alcuadrado
force-pushed
the
hardhat-error-types
branch
from
a495ad9 to
cc7b887
Compare
|
|
||
| template = template.replaceAll(variableTag, value); | ||
| } | ||
| if (Array.isArray(rawValue)) { |
There was a problem hiding this comment.
@schaable when merging this conflict I realized that the hasOwnProperty method didn't allow for classes to define their toString, so I switched it to explicitly handling arrays.
|
It should be easiear to review this one commit at the time. The 4th and 6th commits are just automatic string replacements. |
| string, | ||
| ErrorMessageTemplateValue | ||
| >; | ||
| export type MessagetTemplateArguments<MessageTemplateT extends string> = |
| for (const variableName of Object.keys(values)) { | ||
| let value: string; | ||
|
|
||
| return template.replaceAll(/{(.*?)}/g, (_match, variableName) => { |
There was a problem hiding this comment.
should this match the empty group {}?
There was a problem hiding this comment.
Good catch! But after giving it a few minutes, I think it's better if it matches the behavior of the types. To avoid matching the empty group, the types will be significantly more complex.
I'll add a test for this case.
There was a problem hiding this comment.
Added the tests in 409dc51
| HardhatError.ERRORS.INTERNAL.ASSERTION_ERROR, | ||
| ); | ||
| }); | ||
| describe("MessagetTemplateArguments type", () => { |
There was a problem hiding this comment.
this is a nice example of type testing
Co-authored-by: John Kane <[email protected]>
alcuadrado
force-pushed
the
hardhat-error-types
branch
from
b01ff52 to
409dc51
Compare
This PR modifies
HardhatErrorso that its constructor and itsmessageArgumentsproperty are type-safe.This introduces two extra changes:
{variable}instead of%variable%, as that dramatically simplified this PR.