Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-safe HardhatError #5283

Merged
merged 10 commits into from
May 29, 2024
Merged

Type-safe HardhatError #5283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c304991
Make HardhatError type-safe and use {v} instead of %v%
alcuadrado May 28, 2024
15ff8cf
Update the HardhatError-related tests
alcuadrado May 28, 2024
2a267f0
Type the descriptors as const
alcuadrado May 28, 2024
f264cc0
Update all the error descriptors' templates
alcuadrado May 28, 2024
f4786f9
Update new compilation errors
alcuadrado May 28, 2024
5bfad26
Update new descriptors after rebasing
alcuadrado May 28, 2024
d29cbab
Handle Arrays and BigInt again after rebasing
alcuadrado May 28, 2024
cb8b4e1
Update v-next/hardhat-errors/test/errors.ts
alcuadrado May 29, 2024
b4183e9
Remove unnecessary `void` statements
alcuadrado May 29, 2024
409dc51
Add tests to make it explicit that {} works
alcuadrado May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion v-next/hardhat-build-system/src/internal/solidity/compiler/downloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ export class CompilerDownloader implements ICompilerDownloader {

throw new HardhatError(
HardhatError.ERRORS.SOLC.VERSION_LIST_DOWNLOAD_FAILED,
{},
e,
);
}
Expand Down
1 change: 0 additions & 1 deletion v-next/hardhat-build-system/src/internal/solidity/compiler/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ export class NativeCompiler implements ICompiler {

throw new HardhatError(
HardhatError.ERRORS.SOLC.CANT_RUN_NATIVE_COMPILER,
{},
e,
);
}
Expand Down
Loading
Loading