-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error printing for Hardhat v3 #5455
Merged
+415
−78
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ca5c807
Improve error class for better message formatting
schaable 8e15d30
Format and log error messages by category
schaable e8c221d
Add tests
schaable 0608940
Remove duplicated catch block
schaable 4e584c4
Remove unneeded test
schaable 5ee3f8e
Add spacing
schaable 836c30d
Add a test for an unknown error type
schaable 245b8f9
Cleanup
schaable 53345fe
Added workaround for CI
schaable 9776184
Add CI
schaable 2d80ced
Fix lint
schaable f77d8c0
Add missing types
schaable 9ae0fc5
Fix lint
schaable 0238f0b
Fix test
schaable a08031c
Fix error printing for unknown errors
schaable a0b79ac
Print error messages within main
schaable 8111de5
Pass --show-stack-traces from main
schaable fca9000
Add missing parameter in jsdoc
schaable File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add missing types
- AntonyBlakey/new-build-system
- (#5455)
- build-system-cache-v2
- (#5455)
- build-system-debug
- (#5455)
- bytecode-println
- (#5455)
- codecov-setup
- (#6502, #5455)
- codecov-setup-speed
- (#5455)
- eslint-plugin-immutable-readonly
- (#5455)
- exploration-new-hooks-for-build-system
- (#6208, #5455)
- feature/add-global-dir-to-hh-utils
- (#5455)
- features/port-sentry
- (#5455)
- fix-ignition-types
- (#5455)
- fix/tx-hash-bug-v3
- (#6429, #5455)
- fix/update-network-types
- (#5455)
- flaky
- (#6512, #5455)
- galargh/custom-reporter-formatting
- (#5455)
- galargh/html
- (#5455)
- galargh/promise-await
- (#5455)
- galargh/test-integration
- (#5455)
- hh2/optimism
- (#5455)
- hh3-alpha-tutorial
- (#5455)
- ignition/arbitrum-sepolia-v3
- (#6518, #5455)
- max-buffer
- (#5455)
- move-remaining-v2-providers-alternative-design
- (#5455)
- network-manager
- (#5455)
- node-test-runner-references
- (#5455)
- normalize-builtin-plugin-names
- (#5455)
- op-example
- (#5455)
- optimism/edr-0.8.0
- (#5455)
- optimism/predeploys
- (#5455)
- port-accounts-to-v3-and-part-of-accounts-providers
- (#5455)
- refactor/optimism-api
- (#5455)
- remove-test
- (#5455)
- rename-mocha-plugin
- (#5455)
- resolver
- (#5455)
- revert-5862-unified-test-workflow
- (#5455)
- revert-solcjs-compile-wrapper
- (#5455)
- robust-compiler-downloader-debug
- (#5455)
- should-merge-compilation-jobs-config
- (#6417, #5455)
- slow-imports
- (#5455)
- solidity-config
- (#5455)
- solidity-runCompilationJob-hook
- (#5455)
- solidity-test-messages
- (#6506, #5455)
- solidity-testing-presentation
- (#5455)
- solidity-testing-testing
- (#6500, #5455)
- support-package-exports-bkp-3
- (#5455)
- support-typechain-in-v3
- (#5455)
- test-depednencies-to-compile
- (#5455)
- test/solidity-examples
- (#5455)
- throw-if-mutex-time-out
- (#6510, #5455)
- typechain_compilation_subset
- (#6458, #5455)
- update-logo-narrow-1
- (#5455)
- update-logo-narrow-2
- (#5455)
- update-readmes
- (#5455)
- use-node-23
- (#6496, #5455)
- v-next
- (#5455)
- v-next-pull-request
- (#5455)
- viem-public-client
- (#6268, #5455)
- viem-types-improvements
- (#5455)
- wip/solidity-test-merged
- (#5455)
- wip/solidity-test-showcase
- (#5455)
commit f77d8c0fdd9147db41dd59573a038380c93455c1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd pass this from
main
, so that we keep everything argv parsing there. It's a bit unexpected here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 8111de5