-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Project root resolution #5517
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving before tests are added, but I think this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a minor comment about parameter order
This PR revamps how we manage the project root resolution and how it impacts other parts of the system.
The project root in Hardhat v3 will be the root of the npm package containing the Hardhat config file, or the one containing the CWD if an instance of the HRE is initialized without using a config file.
This PR touches several files, so here's a summary of the changes:
core
package now accepts an optional projectRoot.resolveProjectRoot
helper exposed incore
.hardhat
, and usingcreateHardhatRuntimeEnvironment
) were updated according to the new project root logic./package
module in the utils package.I'm marking this as WIP as I still haven't added tests for the new functionality yet.
Fixes #5436