Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the types of task arguments #5527

Merged
merged 5 commits into from
Jul 28, 2024
Merged

Improve the types of task arguments #5527

merged 5 commits into from
Jul 28, 2024

Conversation

schaable
Copy link
Member

Closes #5434

@schaable schaable added the v-next A Hardhat v3 development task label Jul 16, 2024
@schaable schaable requested a review from alcuadrado July 16, 2024 23:41
@schaable schaable self-assigned this Jul 16, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 5:13pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8bf8959

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jul 16, 2024
@schaable schaable mentioned this pull request Jul 23, 2024
Merged
@schaable schaable force-pushed the improve-task-types branch from 709e8cb to 6339731 Compare July 23, 2024 15:44
alcuadrado
alcuadrado approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just left a suggestion to document a helper type so that it's easier to understand.

@schaable @alcuadrado
Document helper function
8bf8959 
Co-authored-by: Patricio Palladino <[email protected]>
@schaable schaable merged commit 597e760 into v-next Jul 28, 2024
44 of 45 checks passed
@schaable schaable deleted the improve-task-types branch July 28, 2024 17:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@schaable schaable

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaable @alcuadrado