Skip to content

feat: add renameColumn migration step#1654

Closed
zhenkaGo wants to merge 1 commit intoNozbe:masterfrom
zhenkaGo:feat/rename-column-migration
Closed

feat: add renameColumn migration step#1654
zhenkaGo wants to merge 1 commit intoNozbe:masterfrom
zhenkaGo:feat/rename-column-migration

Conversation

@zhenkaGo
Copy link
Copy Markdown

I added the renameColumn migration step.

@radex
Copy link
Copy Markdown
Collaborator

radex commented Sep 1, 2023

Thanks for this! Have you looked at #1211 ? IIRC, there's a similar problem here as with deleting columns - that it may not work for older versions of SQLite. So at the very least there should be a big fat warning about this, or a workaround that works for all versions

@zhenkaGo zhenkaGo force-pushed the feat/rename-column-migration branch 2 times, most recently from f497bb0 to d668f65 Compare September 11, 2023 12:34
@zhenkaGo zhenkaGo force-pushed the feat/rename-column-migration branch from d668f65 to 4c517ae Compare September 19, 2023 13:30
@zhenkaGo zhenkaGo force-pushed the feat/rename-column-migration branch from 4c517ae to ea8771a Compare September 19, 2023 13:39
@zhenkaGo
Copy link
Copy Markdown
Author

Hi @radex. I've looked at #1211. I found a way around this problem for older versions of SQLite. You can read how it solves here. and please check how I implemented it in this PR.

@radex
Copy link
Copy Markdown
Collaborator

radex commented Jun 13, 2024

Thanks @zhenkaGo -- I'll close this PR as the work continues in #1799

@radex radex closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants