Add destroyColumn, renameColumn, and destroyTable migration steps#1799
Add destroyColumn, renameColumn, and destroyTable migration steps#1799skam22 wants to merge 27 commits intoNozbe:masterfrom
Conversation
|
added destroy table migration step as well |
|
@skam22 Thank you for your contribution! I'm seeing some issues, and I'd like to have this feature finished and shipped, so I took the liberty to add more commits to your PR. Thanks! |
|
ok let me know if you need help with anything. |
|
Somewhat related to this PR but it would be nice to be able to reset the entire db (schema, lastPulledAt and all) during/instead of migrations as well so that the backend can be the main source of data and migrations can be simplified for apps that don't require the full offline functionality. I created an issue to ask about it awhile back: #1609 |
…destroy indexed columns
|
@radex resolved conflicts |
|
@radex fwiw I was able to run the tests locally with success by changing the iPhone model to 15 instead of 14 (as is required for Xcode 15.4). scripts/test-ios #!/bin/bash
set -x
set -e
xcodebuild -workspace native/iosTest/WatermelonTester.xcworkspace -scheme 'WatermelonTester' -destination 'name=iPhone 15' test
|
|
Hi, is something holding this PR back from being merged? Is there any help needed? |
|
I would be interested too! :) |
|
It would be great to know what's missing in this PR, @radex . Then others could help. It's been more than 2 years when you take into account the 2 smaller PRs closed in favor of this one |
This PR implements most of the outstanding code changes from
#1671 and #1654.
In addition to resolving those conflicts it has a few minor syntactic / grammatical fixes to match the existing migration approaches.