Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invented is better than Made #167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DeviantEquinox
Copy link

No description provided.

@cinnamongold
Copy link

if this is just for lb yes

@kylepokorski
Copy link
Contributor

nah suggested is better

@DeviantEquinox
Copy link
Author

nah suggested is better

not all suggested combos get accepted.

@kylepokorski
Copy link
Contributor

nah suggested is better

not all suggested combos get accepted.

Invented sounds wrong though

@DeviantEquinox
Copy link
Author

nah suggested is better

not all suggested combos get accepted.

Invented sounds wrong though

no it doesnt it sounds completely fine wdym

@kylepokorski
Copy link
Contributor

kylepokorski commented Feb 15, 2025

"created" is better though

@DeviantEquinox
Copy link
Author

"created" is better though

created has the same issue as Made where its ambiguous on if you are the first person to obtain that element

@kylepokorski
Copy link
Contributor

"created" is better though

created has the same issue as Made where its ambiguous on if you are the first person to obtain that element

but you don't actually "Invent" an element though

Copy link
Owner

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm like 90% sure it says Made in more places than just this, can you update it everywhere

Copy link
Owner

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@@ -190,7 +190,7 @@ func getSort(input string) string {
}
func getLbSort(input string) string {
switch input {
case "made":
case "invented":
return "made"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You literally didn't even change this part?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that didnt show up when i searched your code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait yeah i didn't because that's a variable and I didn't want to cause conflicts elsewhere that was intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are free to change those if you want but I didn't want to risk touching variables with my level of inexperience with Go and the EoD codebase and github

sorry if this effects you nv7 i dont know how to use github
@DeviantEquinox
Copy link
Author

whats wrong with it at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants