-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invented is better than Made #167
base: main
Are you sure you want to change the base?
Conversation
if this is just for lb yes |
nah suggested is better |
not all suggested combos get accepted. |
Invented sounds wrong though |
no it doesnt it sounds completely fine wdym |
"created" is better though |
created has the same issue as Made where its ambiguous on if you are the first person to obtain that element |
but you don't actually "Invent" an element though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm like 90% sure it says Made in more places than just this, can you update it everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -190,7 +190,7 @@ func getSort(input string) string { | |||
} | |||
func getLbSort(input string) string { | |||
switch input { | |||
case "made": | |||
case "invented": | |||
return "made" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You literally didn't even change this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that didnt show up when i searched your code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait yeah i didn't because that's a variable and I didn't want to cause conflicts elsewhere that was intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are free to change those if you want but I didn't want to risk touching variables with my level of inexperience with Go and the EoD codebase and github
sorry if this effects you nv7 i dont know how to use github
whats wrong with it at this point |
No description provided.