Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invented is better than Made #167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Invented is better than Made #167

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db6855f
Invented > Made
DeviantEquinox Feb 12, 2025
2d894f9
Update sorts.go
DeviantEquinox Feb 19, 2025
f29454f
Merge pull request #2 from Nv7-GitHub/main
DeviantEquinox Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eod/pages/lb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (

var lbSorts = []sevcord.Choice{
sevcord.NewChoice("Found", "found"),
sevcord.NewChoice("Made", "made"),
sevcord.NewChoice("Invented", "made"),
sevcord.NewChoice("Votes", "votes"),
sevcord.NewChoice("Signed", "signed"),
sevcord.NewChoice("Imaged", "img"),
Expand Down
2 changes: 1 addition & 1 deletion eod/sorts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func getSort(input string) string {
}
func getLbSort(input string) string {
switch input {
case "made":
case "invented":
return "made"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You literally didn't even change this part?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that didnt show up when i searched your code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait yeah i didn't because that's a variable and I didn't want to cause conflicts elsewhere that was intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are free to change those if you want but I didn't want to risk touching variables with my level of inexperience with Go and the EoD codebase and github

case "imaged", "img":
return "img"
Expand Down