-
Notifications
You must be signed in to change notification settings - Fork 890
Clarify installation instructions: building from source, and guidance for packagers #4780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+23
−11
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just discard this entirely? Autotools is not relevant in the context of current PROJ versions. This just sounds like we're making excuses. In reality the original wording is probably a remnant of a time when we didn't offer versioned docs. If you somehow find yourself with the source code of an old PROJ you can go back to a previous version of the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't really matter to be, but one point is that I was trying to edit somewhat lightly. I don't see it as making excuses so much as being clear about withdrawal timing.
The second point is that people may be coming to a new release from various old releases, perhaps with build scripts, and the build system switch is a big deal -- but it can be described in one brief sentence. README points to unversioned docs, which change, so for any given release, the online version might be from the future. I see the benefit of unconfusing someone as larger than the harm for someone who doesn't care to skip quickly over a sentence.
Happy to drop the remark about autoconf/8.2, if the three of you have a combined opinion.