-
Notifications
You must be signed in to change notification settings - Fork 12k
Add Account framework #5657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Account framework #5657
Conversation
🦋 Changeset detectedLatest commit: 9542779 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
+ name: '', // Not initialized in the context of signer | ||
+ version: '', // Not initialized in the context of signer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the upgradeable transpilation pipeline, we generate the upgradeable versions and the run tests against them. However, ERC-7702 accounts will delegate to an EIP-712 (through ERC7739) contract, so the domain separator will be rebuilt each time without the name
or version
set in the EOA's storage.
In practice, if users are delegating to an upgradeable contract, it should be a proxy pointing to an implementation that uses the EIP712Upgradeable version so that the domain can be initialized (and reinitialized) properly.
Moves the community contracts account abstraction framework to this repository.
Check #5664 before
PR Checklist
npx changeset add
)