-
Notifications
You must be signed in to change notification settings - Fork 209
A game of surface codes demo #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice demo! 🤩
Nothing much to say except minor editing and a few questions/suggestions.
Co-authored-by: David Ittah <[email protected]>
Reverted the base back. It's important that the base branch remains as |
Co-authored-by: Rashid N H M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved :) (from the technical side)
# TODO: Remove this on next release. Currently Catalyst 0.11 pins jaxlib to 0.4.8;\ | ||
$$PYTHON_VENV_PATH/bin/python -m pip install 'numpy<2';\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure Catalyst supports Numpy 2, it just can't be 2.0.0
. Is that related to jaxlib though?
# TODO: Remove this on next release. Currently Catalyst 0.11 pins jaxlib to 0.4.8;\ | |
$$PYTHON_VENV_PATH/bin/python -m pip install 'numpy<2';\ | |
# TODO: Remove this on next release. Currently Catalyst 0.11 pins jaxlib to 0.4.28;\ | |
$$PYTHON_VENV_PATH/bin/python -m pip install 'numpy<2';\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dime10 , it's moreof a pip issue than Catalyst.
When it upgrades jax pip also upgrades all pre-installed packages to their latest version.
I think a better TODO would be
# TODO: Remove this on next release once QML is upgraded to JAX > 0.4.28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying the qml repo currently doesn't work numpy 2 then?
P0 Game of Surface Codes Demo 2025 Q2 [sc-87600]
open question:
do I understand it correct that single X and Z measurements are free, but joint measurements cost 1 🕒?>> yesWhat does it mean that the error probability of the distillation of 15 faulty magic states with$p$ leads to a faulty magic state with probability $35p^3$ , yet, the probability of failure is $(1-p)^n$ ? 🤔>> p is the infidelity of the state, and