Skip to content

A game of surface codes demo #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: dev
Choose a base branch
from
Open

A game of surface codes demo #1355

wants to merge 44 commits into from

Conversation

Qottmann
Copy link
Collaborator

@Qottmann Qottmann commented Apr 22, 2025

P0 Game of Surface Codes Demo 2025 Q2 [sc-87600]

open question:

  • do I understand it correct that single X and Z measurements are free, but joint measurements cost 1 🕒? >> yes
  • What does it mean that the error probability of the distillation of 15 faulty magic states with $p$ leads to a faulty magic state with probability $35p^3$, yet, the probability of failure is $(1-p)^n$? 🤔 >> p is the infidelity of the state, and $35p^3$ is the infidelity of the distilled state. The success chance of not having an error is $(1-p)^n$

Copy link

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

Copy link

github-actions bot commented Apr 22, 2025

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1355
  • Deployment SHA: 0ec01c5c01abf64a35b7190f2328a0db400202db
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

@Qottmann Qottmann requested a review from dime10 April 28, 2025 08:22
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice demo! 🤩

Nothing much to say except minor editing and a few questions/suggestions.

@Qottmann Qottmann changed the base branch from dev to sc-91141-bump-jax May 13, 2025 16:05
@rashidnhm rashidnhm changed the base branch from sc-91141-bump-jax to dev May 13, 2025 16:18
@rashidnhm
Copy link
Collaborator

Reverted the base back. It's important that the base branch remains as dev as that affects how CI behaves

Co-authored-by: Rashid N H M <[email protected]>
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :) (from the technical side)

Comment on lines +83 to +84
# TODO: Remove this on next release. Currently Catalyst 0.11 pins jaxlib to 0.4.8;\
$$PYTHON_VENV_PATH/bin/python -m pip install 'numpy<2';\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure Catalyst supports Numpy 2, it just can't be 2.0.0. Is that related to jaxlib though?

Suggested change
# TODO: Remove this on next release. Currently Catalyst 0.11 pins jaxlib to 0.4.8;\
$$PYTHON_VENV_PATH/bin/python -m pip install 'numpy<2';\
# TODO: Remove this on next release. Currently Catalyst 0.11 pins jaxlib to 0.4.28;\
$$PYTHON_VENV_PATH/bin/python -m pip install 'numpy<2';\

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dime10 , it's moreof a pip issue than Catalyst.

When it upgrades jax pip also upgrades all pre-installed packages to their latest version.

I think a better TODO would be

# TODO: Remove this on next release once QML is upgraded to JAX > 0.4.28

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying the qml repo currently doesn't work numpy 2 then?

@Qottmann Qottmann changed the title [WIP] A game of surface codes demo A game of surface codes demo May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants