-
Notifications
You must be signed in to change notification settings - Fork 209
A game of surface codes demo #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Qottmann
wants to merge
60
commits into
master
Choose a base branch
from
gosc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 50 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
070f413
A game of surface codes demo
Qottmann e01fb52
A game of surface codes demo
Qottmann 0d8e55f
merge
Qottmann c9957a9
intro, context, qubit patches
Qottmann 6c33693
add figure
Qottmann b1504b7
more details
Qottmann cec3353
more high level stuff, really like the examples from the paper
Qottmann aa7b2f5
more updates
Qottmann 7648b50
Basic operations
Qottmann b664d98
compact block
Qottmann 0ead8d5
compact block
Qottmann e470797
compact block
Qottmann 46414da
typos and math mode
Qottmann b434f40
minor tweaks
Qottmann d7240bf
intermedaite and fast blocks
Qottmann 271d21b
typos?
Qottmann 65bb27d
typo
Qottmann 30f3d35
typo
Qottmann f1e6f92
minor things
Qottmann da83cb6
minor things
Qottmann b0159c0
minor things
Qottmann 741fcaa
distillation block
Qottmann 74985c0
full quantum computer minimal setup
Qottmann cae55e8
conclusion - first draft finished
Qottmann 378de58
typos and small things, self review
Qottmann 68d3d43
clarify error probability --> infidelity
Qottmann e55cc46
Merge branch 'master' into dev
actions-user d960e90
Merge branch 'master' into dev
actions-user 2eecb99
Merge branch 'master' into dev
actions-user f1921ae
Merge branch 'master' into dev
actions-user 9ae3031
Merge branch 'master' into dev
actions-user af301f0
Merge branch 'master' into dev
actions-user 93fa12c
Merge branch 'dev' of https://github.com/PennyLaneAI/qml into gosc
Qottmann bc99445
introduce data block
Qottmann eded211
Apply suggestions from code review
Qottmann f125012
.. of quantum computing
Qottmann 6e92353
Merge branch 'gosc' of https://github.com/PennyLaneAI/qml into gosc
Qottmann c024736
expand intermediate design
Qottmann ef2d3f7
attribution
Qottmann f3c121e
Workaround for ensuring we stay on numpy 1.x until next release
rashidnhm d68e261
Trigger CI
rashidnhm d7ae957
Trigger CI
rashidnhm ee9834d
Trigger CI
rashidnhm 82c8528
Try semicolon in comment
rashidnhm 027bd5f
remove upgrade
Qottmann 66c6945
Point pennylane (temporarily) to a new branch
rashidnhm 01b7068
Merge branch 'sc-91141-bump-jax' of https://github.com/PennyLaneAI/qm…
Qottmann bfcf755
reert makefile change
Qottmann 098889b
Update Makefile
Qottmann 0ec01c5
abstract
Qottmann 9cb6151
Merge branch 'master' into dev
actions-user 6064a23
Merge branch 'master' into dev
actions-user bc98eaf
Merge branch 'master' into dev
actions-user fc103a7
Merge branch 'master' into dev
actions-user 88bbef6
Merge branch 'master' into dev
actions-user 6e51773
Merge branch 'master' into dev
actions-user d6106e5
Merge branch 'dev' of https://github.com/PennyLaneAI/qml into gosc
Qottmann 4904a37
add images
Qottmann f3ad46f
update image links
Qottmann 92b2f86
typo
Qottmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+76.9 KB
_static/demonstration_assets/game_of_surface_codes/15-to-1-protocol.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+40.1 KB
_static/demonstration_assets/game_of_surface_codes/Y_measurement_protocol.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.81 KB
_static/demonstration_assets/game_of_surface_codes/ZZ_measurement.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+28.5 KB
_static/demonstration_assets/game_of_surface_codes/auto-corrected-non-clifford.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25 KB
_static/demonstration_assets/game_of_surface_codes/clifford_rotation.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+27 KB
_static/demonstration_assets/game_of_surface_codes/clifford_rotation_356.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+210 KB
_static/demonstration_assets/game_of_surface_codes/compact_block_worst_case.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+54.7 KB
_static/demonstration_assets/game_of_surface_codes/intermediate_block.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.8 KB
_static/demonstration_assets/game_of_surface_codes/intermediate_setup.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+54.4 KB
_static/demonstration_assets/game_of_surface_codes/intermediate_worst_case.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+26.8 KB
_static/demonstration_assets/game_of_surface_codes/magic_state_injection.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.1 KB
_static/demonstration_assets/game_of_surface_codes/non_clifford_rotation.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+34.6 KB
_static/demonstration_assets/game_of_surface_codes/patch_rotation.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+82.8 KB
_static/demonstration_assets/game_of_surface_codes/qubit_definition.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+42.5 KB
_static/demonstration_assets/game_of_surface_codes/qubit_definition_cropped.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
54 changes: 54 additions & 0 deletions
54
demonstrations/tutorial_game_of_surface_codes.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
{ | ||
"title": "A Game of Surface Codes: Large-Scale Quantum Computing with Lattice Surgery", | ||
"authors": [ | ||
{ | ||
"username": "Qottmann" | ||
} | ||
], | ||
"dateOfPublication": "2025-06-30T00:00:00+00:00", | ||
"dateOfLastModification": "2025-06-30T00:00:00+00:00", | ||
"categories": [ | ||
"Quantum Computing", | ||
"Algorithms" | ||
], | ||
"tags": [], | ||
"previewImages": [ | ||
{ | ||
"type": "thumbnail", | ||
"uri": "/_static/demo_thumbnails/regular_demo_thumbnails/thumbnail_fixed_depth_hamiltonian_simulation_via_cartan_decomposition.png" | ||
}, | ||
{ | ||
"type": "large_thumbnail", | ||
"uri": "/_static/demo_thumbnails/large_demo_thumbnails/thumbnail_large_fixed_depth_hamiltonian_simulation_via_cartan_decomposition.png" | ||
} | ||
], | ||
"seoDescription": "A game of surface codes: Exploring space-time tradeoffs in surface code based quantum computation.", | ||
"doi": "", | ||
"references": [ | ||
{ | ||
"id": "Litinski", | ||
"type": "preprint", | ||
"title": "A Game of Surface Codes: Large-Scale Quantum Computing with Lattice Surgery", | ||
"authors": "Daniel Litinski", | ||
"year": "2021", | ||
"publisher": "", | ||
"journal": "", | ||
"doi": "10.22331/q-2019-03-05-128", | ||
"url": "https://arxiv.org/abs/1808.02892" | ||
} | ||
], | ||
"basedOnPapers": ["10.22331/q-2019-03-05-128"], | ||
"referencedByPapers": [], | ||
"relatedContent": [ | ||
{ | ||
"type": "demonstration", | ||
"id": "tutorial_toric_code", | ||
"weight": 1.0 | ||
}, | ||
{ | ||
"type": "demonstration", | ||
"id": "tutorial_mbqc", | ||
"weight": 1.0 | ||
} | ||
] | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure Catalyst supports Numpy 2, it just can't be
2.0.0
. Is that related to jaxlib though?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dime10 , it's moreof a pip issue than Catalyst.
When it upgrades jax pip also upgrades all pre-installed packages to their latest version.
I think a better TODO would be
# TODO: Remove this on next release once QML is upgraded to JAX > 0.4.28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying the qml repo currently doesn't work numpy 2 then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no code in this demo I rebased to
master
. Should I remove this or leave as is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand the reasoning behind this line, so I can't say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason to add it in the first place?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev didnt build due to some versioning/dependency conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the conflict exactly?
The comment mentions Catalyst, but Catalyst doesn't require
numpy<2
.It also mentions JAX, are you saying JAX v0.4.28 is not compatible with
numpy>=2
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
dev
was pinned to numpy<2 for some other reason, that was the main problem afaikslack context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so from the slack context it sounds like this statement is true:
And the problem is that installing a different version of JAX seems to install a different version of NumPy?
Anyway I'll let @rashidnhm answer/close off this thread then, since he seems to have the most context.