chore: add a posthog react playground that does nothing #2514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+19
to
+24
| useEffect(() => { | ||
| const newEvents = events.filter((e) => !eventsWithTimestamp.find((existing) => existing.uuid === e.uuid)) | ||
| if (newEvents.length > 0) { | ||
| setEventsWithTimestamp((prev) => [...prev, ...newEvents.map((e) => ({ ...e, capturedAt: Date.now() }))]) | ||
| } | ||
| }, [events, eventsWithTimestamp]) |
Contributor
There was a problem hiding this comment.
logic: infinite loop: eventsWithTimestamp is in the dependency array but also updated in the effect body
Suggested change
| useEffect(() => { | |
| const newEvents = events.filter((e) => !eventsWithTimestamp.find((existing) => existing.uuid === e.uuid)) | |
| if (newEvents.length > 0) { | |
| setEventsWithTimestamp((prev) => [...prev, ...newEvents.map((e) => ({ ...e, capturedAt: Date.now() }))]) | |
| } | |
| }, [events, eventsWithTimestamp]) | |
| useEffect(() => { | |
| const newEvents = events.filter((e) => !eventsWithTimestamp.find((existing) => existing.uuid === e.uuid)) | |
| if (newEvents.length > 0) { | |
| setEventsWithTimestamp((prev) => [...prev, ...newEvents.map((e) => ({ ...e, capturedAt: Date.now() }))]) | |
| } | |
| }, [events]) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: playground/react-nextjs/app/EventDisplay.tsx
Line: 19:24
Comment:
**logic:** infinite loop: `eventsWithTimestamp` is in the dependency array but also updated in the effect body
```suggestion
useEffect(() => {
const newEvents = events.filter((e) => !eventsWithTimestamp.find((existing) => existing.uuid === e.uuid))
if (newEvents.length > 0) {
setEventsWithTimestamp((prev) => [...prev, ...newEvents.map((e) => ({ ...e, capturedAt: Date.now() }))])
}
}, [events])
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
There was a problem hiding this comment.
I think greptile is right on this, it looks like an infinite loop
Member
Author
There was a problem hiding this comment.
hmmm, it didn't have a problem in the UI. you'd hope react is clever than that 🫠
Contributor
|
Size Change: 0 B Total Size: 4.86 MB ℹ️ View Unchanged
|
This was referenced Oct 28, 2025
pauldambra
force-pushed
the
chore/react-play
branch
from
bf050dc to
7dd3ef8
Compare
hpouillot
reviewed
Oct 29, 2025
| }, | ||
| "dependencies": { | ||
| "next": "14.2.33", | ||
| "posthog-js": "*", |
Contributor
There was a problem hiding this comment.
if you import like this you will need to update the pnpm-workspace to use the pnpmfile inside playground folder. You can have a look at nextjs playground to see a example
hpouillot
approved these changes
Oct 29, 2025
Member
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2504 had some weird unrelated surveys failure
so let's split it up and see what the what
importantly that let me see this playground was bootstrapped in the previous PR with different versions of things, let's avoid that!