chore: rearrange things for re-use within the react SDK #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Contributor
|
Size Change: 0 B Total Size: 4.86 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1
to
+48
| import React, { MouseEventHandler, useEffect, useMemo, useRef } from 'react' | ||
| import { isNull } from '../../utils/type-utils' | ||
|
|
||
| /** | ||
| * VisibilityAndClickTracker is an internal component, | ||
| * its API might change without warning and without being signalled as a breaking change | ||
| * | ||
| */ | ||
| export function VisibilityAndClickTracker({ | ||
| children, | ||
| onIntersect, | ||
| onClick, | ||
| trackView, | ||
| options, | ||
| ...props | ||
| }: { | ||
| children: React.ReactNode | ||
| onIntersect: (entry: IntersectionObserverEntry) => void | ||
| onClick?: MouseEventHandler<HTMLDivElement> | ||
| trackView: boolean | ||
| options?: IntersectionObserverInit | ||
| }): JSX.Element { | ||
| const ref = useRef<HTMLDivElement>(null) | ||
|
|
||
| const observerOptions = useMemo( | ||
| () => ({ | ||
| threshold: 0.1, | ||
| ...options, | ||
| }), | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [options?.threshold, options?.root, options?.rootMargin] | ||
| ) | ||
|
|
||
| useEffect(() => { | ||
| if (isNull(ref.current) || !trackView) return | ||
|
|
||
| // eslint-disable-next-line compat/compat | ||
| const observer = new IntersectionObserver(([entry]) => onIntersect(entry), observerOptions) | ||
| observer.observe(ref.current) | ||
| return () => observer.disconnect() | ||
| }, [observerOptions, trackView, onIntersect]) | ||
|
|
||
| return ( | ||
| <div ref={ref} {...props} onClick={onClick}> | ||
| {children} | ||
| </div> | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
logic: This file is a duplicate of VisibilityAndClickTracker.tsx (singular). Both files contain identical code. One should be deleted.
Based on PostHogFeature.tsx, there should be TWO different components:
VisibilityAndClickTracker(inner/simpler component)VisibilityAndClickTrackers(outer wrapper with flag tracking)
Currently both files export the same simpler component.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react/src/components/internal/VisibilityAndClickTrackers.tsx
Line: 1:48
Comment:
**logic:** This file is a duplicate of `VisibilityAndClickTracker.tsx` (singular). Both files contain identical code. One should be deleted.
Based on `PostHogFeature.tsx`, there should be TWO different components:
- `VisibilityAndClickTracker` (inner/simpler component)
- `VisibilityAndClickTrackers` (outer wrapper with flag tracking)
Currently both files export the same simpler component.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+25
to
+32
| const observerOptions = useMemo( | ||
| () => ({ | ||
| threshold: 0.1, | ||
| ...options, | ||
| }), | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [options?.threshold, options?.root, options?.rootMargin] | ||
| ) |
Contributor
There was a problem hiding this comment.
logic: The useMemo dependency array is incomplete. The original in PostHogFeature.tsx:106-116 uses a different pattern without useMemo, passing options directly to IntersectionObserver.
This useMemo approach could cause issues - if other properties of options change (not just threshold/root/rootMargin), the observer won't be recreated because observerOptions won't change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react/src/components/internal/VisibilityAndClickTracker.tsx
Line: 25:32
Comment:
**logic:** The `useMemo` dependency array is incomplete. The original in `PostHogFeature.tsx:106-116` uses a different pattern without `useMemo`, passing options directly to `IntersectionObserver`.
This `useMemo` approach could cause issues - if other properties of `options` change (not just threshold/root/rootMargin), the observer won't be recreated because `observerOptions` won't change.
How can I resolve this? If you propose a fix, please make it concise.| }: { | ||
| children: React.ReactNode | ||
| onIntersect: (entry: IntersectionObserverEntry) => void | ||
| onClick?: MouseEventHandler<HTMLDivElement> |
Contributor
There was a problem hiding this comment.
logic: onClick is optional here but required in the original PostHogFeature.tsx:99. This API inconsistency could lead to bugs when these components are actually used.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react/src/components/internal/VisibilityAndClickTracker.tsx
Line: 19:19
Comment:
**logic:** `onClick` is optional here but required in the original `PostHogFeature.tsx:99`. This API inconsistency could lead to bugs when these components are actually used.
How can I resolve this? If you propose a fix, please make it concise.
This was referenced Oct 28, 2025
pauldambra
force-pushed
the
chore/react-play
branch
from
bf050dc to
7dd3ef8
Compare
pauldambra
force-pushed
the
chore/rearrange-things-for-re-use
branch
from
e4f12fb to
7caa257
Compare
hpouillot
approved these changes
Oct 29, 2025
pauldambra
changed the base branch from
chore/react-play
to
graphite-base/2515
pauldambra
force-pushed
the
chore/rearrange-things-for-re-use
branch
from
7caa257 to
e00ce28
Compare
pauldambra
force-pushed
the
graphite-base/2515
branch
from
7dd3ef8 to
465f7e2
Compare
pauldambra
force-pushed
the
chore/rearrange-things-for-re-use
branch
from
e00ce28 to
bee42de
Compare
Member
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2504 had weird unrelated build errors, let's split it up
i know i need to reuse the visibility and click trackers that are hidden in PostHogFeature, so split them out