-
Notifications
You must be signed in to change notification settings - Fork 6
Calculations in key-figures.ipynb
take too long
#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I doubt that we'll be able to use Dask (or at least use it effectively) on GitHub Actions. It would be good to figure out why those cells are not running. According to the docs here: |
@r-ford do you want to take a look at updating the infrastructure in this repo (ProjectPythia/cookbook-gallery#96) and see if executing on the binder will fix this? If so we can also close ProjectPythia/cookbook-gallery#12 |
@brian-rose I just updated the infrastructure, but it looks like there is an error with the code in one of the notebooks:
Maybe some of this code is outdated? |
@r-ford ok, I guess we'll have to take a deeper dive into the code. Seems like some sort of conflict with the intake_esm catalog. |
We'll try to get this running before the AGU meeting. |
@brian-rose @r-ford @clyne I am making some progress fixing the problematic code cells (the |
Hmmm there appears to be a new Pangeo binder running on AWS: https://hub.aws-uswest2-binder.pangeo.io/ I wonder if that's a better platform for running this code, since the data are in S3 storage. |
There's an authentication step that uses GitHub user account. I'm not sure what will happen if we just set
in the config file. |
@brian-rose Given that (at present) we don't know how to leverage binderbot to use authentication, and the fact that this notebook takes north of an hour to run, I think it would be better to present this notebook as HTML, in its fully-rendered format after it has successfully run locally, but not have it run via github actions or binderbot. This way we would at least be able to include it in the cookbook. |
I think this makes sense for now. If we're expecting some more readers soon, it would be nice if they could at least see the output. |
@ktyle @r-ford agreed that committing a pre-executed version of this notebook is an acceptable short-term solution, given that it has useful content and that we are actively pursuing solutions for reproducible health checks etc. I left some notes in #12 about how to implement this and get the whole Cookbook successfully building and publishing itself. |
We will revisit when the new Binderhub is up and running |
Similar to this issue in the CMIP6 Cookbook,
key-figures.ipynb
is too much for GitHub Actions to build, so the cell outputs are not included. In this case, though, I can't just cut out some material.I'm not sure that Dask is actually implemented properly in this notebook, so a solution to this issue could just be using Dask to speed up the computation.
The text was updated successfully, but these errors were encountered: