Open
Conversation
Quipyowert2
force-pushed
the
resolve-warnings
branch
from
536cfa2 to
e6ed8d0
Compare
Quipyowert2
force-pushed
the
resolve-warnings
branch
from
e6ed8d0 to
d6986b4
Compare
Quipyowert2
commented
Sep 30, 2023
| continue; | ||
| sample_ptr = KXL_SoundData.PlaySound[i].Pos+KXL_SoundData.PlaySound[i].Cnt; | ||
| sample_size = MIN(max_sample_size, KXL_SoundData.PlaySound[i].Length - KXL_SoundData.PlaySound[i].Cnt); | ||
| sample_size = MIN(max_sample_size, ((Sint32)KXL_SoundData.PlaySound[i].Length) - (Sint32)KXL_SoundData.PlaySound[i].Cnt); |
Owner
Author
There was a problem hiding this comment.
Is it possible for the length to overflow if it is > ~2 GB?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a comparison between signed and unsigned and a incompatible pointer type warning. I originally solved the incompatible pointer type issue by using preprocessor macros, but
int32_tis so much cleaner and concise.The first warning, at KXLsound.c:148, goes away after casting some unsigneds to signed when subtracting; the second, at KXLsound.c:282, is fixed by changing the
Sint32type to beint32_twhich is always 32-bits, rather thanlong, which can either be the same size asintor larger, and is definitely not the same type. I also changed the type ofUint32touint32_tfor consistency.