Skip to content

Resolve warnings #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quipyowert2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolve warnings #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76e618
Fix a warning about comparing signed and unsigned.
Quipyowert2 Sep 15, 2023
d6986b4
Fix pipe giving incompatible pointer type warning.
Quipyowert2 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/KXL.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
#define _KXLIB_H_

#include <stdio.h>
#include <stdint.h>
#include <limits.h>
#include <X11/Xlib.h>
#include <X11/Xutil.h>

Expand Down Expand Up @@ -152,8 +154,8 @@ typedef signed char Sint8;
typedef unsigned char Uint8;
typedef signed short Sint16;
typedef unsigned short Uint16;
typedef signed long Sint32;
typedef unsigned long Uint32;
typedef int32_t Sint32;
typedef uint32_t Uint32;
// Image
typedef struct {
Pixmap Buffer; // Drawing image
Expand Down
2 changes: 1 addition & 1 deletion src/KXLsound.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ void KXL_SoundServer(void)
if (KXL_SoundData.PlaySound[i].Active == False)
continue;
sample_ptr = KXL_SoundData.PlaySound[i].Pos+KXL_SoundData.PlaySound[i].Cnt;
sample_size = MIN(max_sample_size, KXL_SoundData.PlaySound[i].Length - KXL_SoundData.PlaySound[i].Cnt);
sample_size = MIN(max_sample_size, ((Sint32)KXL_SoundData.PlaySound[i].Length) - (Sint32)KXL_SoundData.PlaySound[i].Cnt);
Copy link
Owner Author

@Quipyowert2 Quipyowert2 Sep 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for the length to overflow if it is > ~2 GB?

KXL_SoundData.PlaySound[i].Cnt += sample_size;
memcpy(KXL_SoundData.FBuff, sample_ptr, sample_size);
if (KXL_SoundData.PlaySound[i].Action == KXL_SOUND_PLAY_LOOP &&
Expand Down