Skip to content

Add some bsp driver for HC32F4A8. #10333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JamieTx
Copy link
Contributor

@JamieTx JamieTx commented May 28, 2025

拉取/合并请求描述:(PR description)

[
Add some bsp driver for HC32F4A8.
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label May 28, 2025
@supperthomas supperthomas requested a review from Copilot May 28, 2025 08:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support and driver updates for the HC32F4A8 MCU variant, extending existing HAL layers and board configurations.

  • Enable HC32F4A8 in RTC, PM, MCAN, ETH, and DAC drivers
  • Introduce VBAT power-down check for RTC initialization
  • Update board-specific ports, Kconfig entries, and application code for F4A8

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
bsp/hc32/libraries/hc32_drivers/drv_rtc.c Add F4A8 support and VBAT power-down check
bsp/hc32/libraries/hc32_drivers/drv_pm.h Extend EFM readiness check to F4A8
bsp/hc32/libraries/hc32_drivers/drv_pm.c Include F4A8 in deep-sleep and run-mode transitions
bsp/hc32/libraries/hc32_drivers/drv_mcan.c Update MCAN ISR to accept int_sel parameter
bsp/hc32/libraries/hc32_drivers/drv_eth.c Adapt PHY address handling and auto-negotiation config for F4A8
bsp/hc32/libraries/hc32_drivers/drv_dac.h Extend DAC init struct with new F4A8 channel parameters
bsp/hc32/libraries/hc32_drivers/drv_dac.c Implement channel init logic for F4A8 DAC ports
bsp/hc32/ev_hc32f4a8_lqfp176/board/{ports,config,board_config.c,hc32f4xx_conf.h,Kconfig} Add board-level port mappings, DAC/Kconfig updates, and FCM application changes for F4A8
Comments suppressed due to low confidence (2)

bsp/hc32/libraries/hc32_drivers/drv_rtc.c:202

  • [nitpick] The function VBAT_PowerDownCheck uses PascalCase and no underscore prefix, which is inconsistent with other static helper functions; consider renaming to _vbat_power_down_check to match existing naming conventions.
static en_flag_status_t VBAT_PowerDownCheck(void)

bsp/hc32/libraries/hc32_drivers/drv_mcan.c:862

  • The mcan_isr definition was changed to accept two parameters, but any forward declarations or other references expecting a single-parameter signature will break; ensure the prototype is updated everywhere (including headers) to match this new signature.
rt_inline void mcan_isr(hc32_mcan_driver_t *driver, uint32_t int_sel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant