Repository navigation
Conversation
lizschwab
commented
Nov 17, 2026
| const puppeteer = await driver.getPuppeteer(); | ||
| const [page] = await puppeteer.pages(); | ||
| const session = await page.createCDPSession(); | ||
| await session.send('Emulation.setFocusEmulationEnabled', {enabled: true}); |
Contributor
Author
There was a problem hiding this comment.
While testing the browser tests to ensure my changes worked, I kept getting failures on focus manager tests. This addresses that by stubbing out the window's focus state, making it so the tests no longer fail if the chrome window is not currently focused.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes the tests which were broken when plugins that are imported into the test framework were updated to ESM.
Proposed Changes
@blockly/block-testand uses the global blockly instead of using its own copy of blocklyReason for Changes
Updating plugins to ESM broke some of our tests. This resolves those issues.
Additional Information
AI was used to troubleshoot the problem with the tests and to draft the fix. I tested the changes, reviewed the code, and wrote the summary.