Repository navigation
chore: Fix tests broken by plugin ESM updates #10693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lizschwab
wants to merge
1
commit into
RaspberryPiFoundation:plugin-esm
Choose a base branch
from
lizschwab:plugins-esm-fix-tests
base: plugin-esm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2026 Raspberry Pi Foundation | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| /** | ||
| * @fileoverview Bundles `@blockly/block-test` for test harnesses that load | ||
| * Blockly as a global rather than importing it. | ||
| */ | ||
|
|
||
| import {build} from 'esbuild'; | ||
|
|
||
| /** | ||
| * Bundles `@blockly/block-test` into a classic script. | ||
| * | ||
| * The bundle uses the global Blockly rather than including its own copy, so | ||
| * the test blocks register with the Blockly the tests run against. Running it | ||
| * also exposes toolboxTestBlocks and toolboxTestBlocksInit on globalThis. | ||
| * @returns {Promise<string>} The source of the bundled script. | ||
| */ | ||
| export async function bundleBlockTest() { | ||
| const {outputFiles} = await build({ | ||
| stdin: { | ||
| contents: ` | ||
| import {toolboxTestBlocks, toolboxTestBlocksInit} from '@blockly/block-test'; | ||
| globalThis.toolboxTestBlocks = toolboxTestBlocks; | ||
| globalThis.toolboxTestBlocksInit = toolboxTestBlocksInit; | ||
| `, | ||
| resolveDir: import.meta.dirname, | ||
| }, | ||
| bundle: true, | ||
| write: false, | ||
| format: 'iife', | ||
| plugins: [ | ||
| { | ||
| name: 'global-blockly', | ||
| setup(build) { | ||
| build.onResolve({filter: /^blockly\/core$/}, () => ({ | ||
| path: 'blockly/core', | ||
| namespace: 'global-blockly', | ||
| })); | ||
| build.onLoad({filter: /.*/, namespace: 'global-blockly'}, () => ({ | ||
| contents: 'module.exports = globalThis.Blockly;', | ||
| })); | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
| return outputFiles[0].text; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing the browser tests to ensure my changes worked, I kept getting failures on focus manager tests. This addresses that by stubbing out the window's focus state, making it so the tests no longer fail if the chrome window is not currently focused.