Skip to content

Conversation

@815are
Copy link
Contributor

@815are 815are commented Oct 6, 2025

Version for Integration test for fiori MCP using promptfoo -> https://github.com/SAP/open-ux-tools/tree/feat/mcpServerPromptFooIntTest/packages/fiori-mcp-server/test/integration

Current commands/scripts:

  1. pnpm test:integration:once - run tests single time;
  2. pnpm test:integration:multiple - run each test 5 times;
  3. pnpm view:integration - opens promptfoo view with test runs history;

Structure:

integration
├── assertions - contains custom assertion function to validate snapshots
├── extensions - contains extension points to handle beforeEach/beforeAll to copy fresh project before running test scenario
├── provider - custom promptfoo provider which uses @sap-ai-sdk and add tools from fiori mcp server
├── scenarios - contains prmotfoo config yaml file and tests separated into subfolders
├── snapshots - contains snapshots files which then used by assertion
├── test-data
│   ├── copy - copied project during test execution
│   └── original - contains all original apps which will be copied when test is executed(if project is listed in config of test)
└── types - separate folder for reusable types, currently only constants with folder paths

Current tests -> https://github.com/SAP/open-ux-tools/tree/feat/mcpServerPromptFooIntTest/packages/fiori-mcp-server/test/integration/scenarios

image

Additional change in https://github.com/SAP/open-ux-tools/blob/main/packages/fiori-mcp-server/src/types/input.ts - description for ExecuteFunctionalityInputSchema is updated as sometimes parameters was not passed within parameters object, but outside of parameters property

very first version
@815are 815are added the fiori-mcp @sap-ux/fiori-mcp label Oct 6, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

🦋 Changeset detected

Latest commit: 8556d73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

815are added 2 commits October 6, 2025 20:03
project path
dependencies resolution update
@815are 815are force-pushed the feat/mcpServerPromptFooIntTest branch from 3ee8e61 to ccb9083 Compare October 8, 2025 10:38
@815are 815are force-pushed the feat/mcpServerPromptFooIntTest branch from 8ae5c40 to 0a849db Compare November 7, 2025 13:14
vinayhospete
vinayhospete previously approved these changes Nov 10, 2025
marufrasully
marufrasully previously approved these changes Nov 10, 2025
Copy link
Contributor

@donal-tobin-sap donal-tobin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock from test should not be added to source control

review comment
@815are 815are dismissed stale reviews from marufrasully and vinayhospete via 8556d73 November 10, 2025 12:10
@815are
Copy link
Contributor Author

815are commented Nov 10, 2025

package-lock from test should not be added to source control

@donal-tobin-sap
2 lock files from test project were removed within commit -> 8556d73

@sonarqubecloud
Copy link

Copy link
Contributor

@donal-tobin-sap donal-tobin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look to be fine to me.

@815are 815are merged commit bfbdb77 into main Nov 10, 2025
16 checks passed
@815are 815are deleted the feat/mcpServerPromptFooIntTest branch November 10, 2025 12:24
devinea added a commit that referenced this pull request Nov 10, 2025
* origin/main:
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
tom-sap added a commit that referenced this pull request Nov 11, 2025
* main: (105 commits)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  chore: apply latest changesets
  fix: bump fallback versions (#3813)
  chore: apply latest changesets
  chore - upgrade ui5 devDeps (#3771)
  correct publisher to SAPOSS (#3817)
  chore: apply latest changesets
  fix: cloud system render logic, message wording, test connection logging (#3811)
  chore: apply latest changesets
  chore: bump application insights to 2.9.8 (#3812)
  chore: apply latest changesets
  fix(fiori-mcp): instrumentation key replacement (#3810)
  ...
devinea added a commit that referenced this pull request Nov 11, 2025
* origin/main:
  chore: apply latest changesets
  feat(create): auto generate readme on build (#3760)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  chore: apply latest changesets
  fix: bump fallback versions (#3813)
eouin added a commit that referenced this pull request Nov 11, 2025
…ter/building-block-custom-filter

* 'main' of github.com:SAP/open-ux-tools: (32 commits)
  chore: apply latest changesets
  feat(create): auto generate readme on build (#3760)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  chore: apply latest changesets
  fix: bump fallback versions (#3813)
  chore: apply latest changesets
  chore - upgrade ui5 devDeps (#3771)
  correct publisher to SAPOSS (#3817)
  chore: apply latest changesets
  fix: cloud system render logic, message wording, test connection logging (#3811)
  chore: apply latest changesets
  chore: bump application insights to 2.9.8 (#3812)
  ...
devinea added a commit that referenced this pull request Nov 11, 2025
…i_custom_into_fiori_tools_plugin

* origin/eslint9: (52 commits)
  chore: apply latest changesets
  update building block svg (#3826)
  chore: apply latest changesets
  feat(create): auto generate readme on build (#3760)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  chore: apply latest changesets
  fix: bump fallback versions (#3813)
  chore: apply latest changesets
  chore - upgrade ui5 devDeps (#3771)
  correct publisher to SAPOSS (#3817)
  chore: apply latest changesets
  fix: cloud system render logic, message wording, test connection logging (#3811)
  ...
devinea added a commit that referenced this pull request Nov 11, 2025
…fiori_tools_plugin' into eslint9_merge_fiori_custom_into_fiori_tools_plugin_update_templates

* origin/eslint9_merge_fiori_custom_into_fiori_tools_plugin:
  chore: apply latest changesets
  update building block svg (#3826)
  chore: apply latest changesets
  feat(create): auto generate readme on build (#3760)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  chore: apply latest changesets
  fix: bump fallback versions (#3813)
devinea added a commit that referenced this pull request Nov 12, 2025
* origin/main: (31 commits)
  chore: apply latest changesets
  fix: improve handling for saving systems (#3828)
  chore: apply latest changesets
  chore: Update `@sap/cf-tools` version to latest to avoid security issues (#3809)
  chore: apply latest changesets
  feat(fiori-docs-embeddings): add @sap-ux/create/README.md as resource (#3779)
  fix: run tests on windows (#3823)
  chore: apply latest changesets
  update building block svg (#3826)
  chore: apply latest changesets
  feat(create): auto generate readme on build (#3760)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fiori-mcp @sap-ux/fiori-mcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants