Skip to content

Safety make_zero! on repeated Enzyme calls with caches #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 19, 2025
Merged

Safety make_zero! on repeated Enzyme calls with caches #1067

merged 14 commits into from
May 19, 2025

Conversation

ChrisRackauckas
Copy link
Member

This should ensure that the caches are always zero'd for the derivatives.

@ChrisRackauckas ChrisRackauckas mentioned this pull request Jun 9, 2024
Closed
5 tasks
wsmoses
wsmoses reviewed Jun 10, 2024
View reviewed changes
wsmoses
wsmoses reviewed Jun 10, 2024
View reviewed changes
@ChrisRackauckas
Copy link
Member Author

It looks like it fails on a trivial closure?

https://github.com/SciML/SciMLSensitivity.jl/actions/runs/9501768875/job/26188120021?pr=1067#step:6:688

@ChrisRackauckas
Copy link
Member Author

For some reason this function fails Enzyme.Compiler.guaranteed_const_nongen(typeof(_pf), nothing) false and then in the next iterate it errors. It seems like make_zero! is not robust to active values in closures?

@ChrisRackauckas ChrisRackauckas mentioned this pull request Jun 29, 2024
Closed
@ChrisRackauckas ChrisRackauckas mentioned this pull request Jul 6, 2024
Merged
ChrisRackauckas
ChrisRackauckas commented Jul 9, 2024
View reviewed changes
@ChrisRackauckas ChrisRackauckas mentioned this pull request Jul 15, 2024
Merged
@ChrisRackauckas ChrisRackauckas mentioned this pull request Jul 22, 2024
Open
@ChrisRackauckas
Copy link
Member Author

Current error is EnzymeAD/Enzyme.jl#1661

@ChrisRackauckas ChrisRackauckas mentioned this pull request May 19, 2025
Open
@ChrisRackauckas ChrisRackauckas merged commit 24e9fde into master May 19, 2025
26 of 30 checks passed
@ChrisRackauckas ChrisRackauckas deleted the makezerobang branch May 19, 2025 02:35
@ChrisRackauckas ChrisRackauckas mentioned this pull request May 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisRackauckas @wsmoses