WHL: add Windows32 + musllinux wheels #2581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can someone add the "Run cibuildwheel" label please ? |
QuLogic
requested changes
Oct 2, 2025
| CIBW_BUILD: "cp310-* cp311-* cp312-* cp313-*" | ||
| # Skip 32 bit builds and musllinux due to lack of numpy wheels | ||
| CIBW_SKIP: "*-win32 *_i686 *-musllinux*" | ||
| CIBW_SKIP: "*_i686" |
There was a problem hiding this comment.
The win32 wheels didn't build (I guess cibuildwheel stopped building them by default), so while removing the skip makes sense, it's incongruent with the explanation in the commit/PR message now.
There was a problem hiding this comment.
nice catch.
I guess cibuildwheel stopped building them by default
it actually depends on the native arch + settings, and the latter currently excludes 32 bits builds.
I'll adjust the arch option correspondingly.
neutrinoceros
force-pushed
the
whl/additional-targets
branch
from
d8137e6 to
3eaf9a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Maybe this won't work out of the box, but I noticed the documented reason for skipping these targets was obsolete; numpy in fact has wheels for both, so let's give it a spin
Implications
More supported platforms.