Skip to content

WHL: add Windows32 + musllinux wheels #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WHL: add Windows32 + musllinux wheels #2581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- os: ubuntu-latest
cibw_archs: "x86_64"
- os: windows-latest
cibw_archs: "auto64"
cibw_archs: "auto"
- os: macos-latest
cibw_archs: "x86_64"
- os: macos-latest
Expand All @@ -99,8 +99,7 @@ jobs:
package-dir: dist/${{ needs.build_sdist.outputs.SDIST_NAME }}
env:
CIBW_BUILD: "cp310-* cp311-* cp312-* cp313-*"
# Skip 32 bit builds and musllinux due to lack of numpy wheels
CIBW_SKIP: "*-win32 *_i686 *-musllinux*"
CIBW_SKIP: "*_i686"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The win32 wheels didn't build (I guess cibuildwheel stopped building them by default), so while removing the skip makes sense, it's incongruent with the explanation in the commit/PR message now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

I guess cibuildwheel stopped building them by default

it actually depends on the native arch + settings, and the latter currently excludes 32 bits builds.
I'll adjust the arch option correspondingly.

CIBW_ARCHS: ${{ matrix.cibw_archs }}

- uses: actions/upload-artifact@v4
Expand Down
Loading