Skip to content

fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results #9207

wants to merge 3 commits into from
+2 −1

Conversation

gopnik5
Copy link
Contributor

@gopnik5 gopnik5 commented May 28, 2025 •
edited
Loading

Issue #8781:
fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9c25bfe.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 6s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-02 16:17:28 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 28, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9207

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9207

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9207

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9207

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9207

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9207

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9207

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9207

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9207

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9207

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9207

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9207

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9207

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9207

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9207

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9207

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9207

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9207

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9207

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9207

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9207

commit: 9c25bfe

@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.62%. Comparing base (b475d21) to head (9c25bfe).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9207       +/-   ##
===========================================
+ Coverage   45.30%   59.62%   +14.31%     
===========================================
  Files         209      138       -71     
  Lines        8257     5496     -2761     
  Branches     1856     1481      -375     
===========================================
- Hits         3741     3277      -464     
+ Misses       4076     1922     -2154     
+ Partials      440      297      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.04% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 98.08% <0.00%> (-0.06%) ⬇️
@tanstack/query-devtools 3.56% <ø> (ø)
@tanstack/query-persist-client-core 78.32% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 96.02% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.85% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 2, 2025

please add a test that fails on main and is fixed with this PR. Otherwise, we a) don’t know what this fixes and b) it might regress again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gopnik5 @TkDodo