Skip to content

fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results #9207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdc904a
fix(query-core): add check to #combineResult for input parameter leng…
gopnik5 May 28, 2025
1e28631
Merge branch 'main' into combine_bug
gopnik5 May 28, 2025
9c25bfe
Merge branch 'main' into combine_bug
TkDodo Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/query-core/src/queriesObserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@
if (
!this.#combinedResult ||
this.#result !== this.#lastResult ||
combine !== this.#lastCombine
combine !== this.#lastCombine ||
this.#result.length !== input.length

Check warning on line 211 in packages/query-core/src/queriesObserver.ts

View check run for this annotation

Codecov / codecov/patch

packages/query-core/src/queriesObserver.ts#L210-L211 

Added lines #L210 - L211 were not covered by tests
) {
this.#lastCombine = combine
this.#lastResult = this.#result
Expand Down
Loading