Conversation
…ebuilt into 13-turret-initial-code # Conflicts: # src/main/java/frc/robot/subsystems/turret/Turret.java # src/main/java/frc/robot/subsystems/turret/TurretIOSensorInputs.java
…ebuilt into 13-turret-initial-code
…hot compensation logic
# Conflicts: # src/main/java/frc/robot/CanID.java # src/main/java/frc/robot/RobotContainer.java # src/main/java/frc/robot/subsystems/vision/Vision.java # src/main/java/frc/robot/subsystems/vision/photon/Camera.java
Closed
NathanEdg
previously requested changes
Feb 20, 2026
src/main/java/frc/robot/subsystems/turret/calc/ShotCompensation.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/turret/TurretIOSensorInputs.java
Outdated
Show resolved
Hide resolved
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
src/main/java/frc/robot/subsystems/drive/CommandSwerveDrivetrain.java
Outdated
Show resolved
Hide resolved
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
src/main/java/frc/robot/subsystems/turret/calc/ShotCompensation.java
Outdated
Show resolved
Hide resolved
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 20, 2026
bjmcternan
reviewed
Feb 23, 2026
bjmcternan
reviewed
Feb 23, 2026
bjmcternan
reviewed
Feb 23, 2026
bjmcternan
requested changes
Feb 23, 2026
Contributor
bjmcternan
left a comment
There was a problem hiding this comment.
Some cleanup we can do. Might be best to discuss it in a huddle
bjmcternan
reviewed
Feb 24, 2026
src/main/java/frc/robot/subsystems/turret/TurretIOSensorInputs.java
Outdated
Show resolved
Hide resolved
This reverts commit 1abef26.
This reverts commit 07ba2b5.
* Add shooter subsystem with shot compensation logic and CAN ID updates * Add shooter subsystem initialization in RobotContainer * Refactor shooter and turret subsystems to use new Targeting subsystem and remove old pubsub system * Integrate shooter and turret dependencies into indexer subsystem and enhance ball feeding logic
Closed
afranchuk
previously requested changes
Feb 27, 2026
Co-authored-by: Brennan <bjmcternan@users.noreply.github.com>
Contributor
|
We just sat down and went over this code. I think this looks good now. There's some outstanding tasks that we need to address but this is a good start to get into develop. |
Stale, will address comments in another PR. Thanks
…ebuilt into 13-turret-initial-code
NathanEdg
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial turret code with CRT controlling a table top turret. This is transferrable to the actual turret, just need to change a few variables for CRT.
Closes #13