Fixed inconsistent inclusion of padding files in tdef #8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
fix_files_info_no_md
branch
from
ecee858 to
771a363
Compare
qstokkink
changed the title
egbertbouman
approved these changes
Mar 7, 2025
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8366
Fixes #8468
This PR:
_get_all_files_as_unicode_with_lengthincluding padding files for v1 metainfo.This is a tiny step toward leaning more on the
torrent_infoin theTorrentDef. Looking at it, we can probably replace_get_all_files_as_unicode_with_lengthwith about three lines of code, if we lean ontorrent_deffully. That's for a future PR though.