Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ForwardDiff in [weakdeps] to 1, (keep existing compat) #864

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ForwardDiff package from 0.10.12 to 0.10.12, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2025-03-27-00-11-03-080-01636651742 branch from 319861c to 7f4d023 Compare March 27, 2025 00:11
Copy link
Contributor Author

github-actions bot commented Mar 27, 2025

Benchmark Report for Commit 38f5be1

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                 10.2 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                629.6 |                41.1 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                431.3 |                45.5 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1249.0 |                27.1 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               4273.0 |                19.5 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1517.3 |                29.0 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                973.9 |                 5.2 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5713.1 |                 4.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1110.6 |                 8.4 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              62578.5 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               9188.5 |                 9.6 |
|               Dynamic |        10 |    mooncake |             typed |   true |                133.7 |                12.3 |
|              Submodel |         1 |    mooncake |             typed |   true |                 26.7 |                 8.5 |
|                   LDA |        12 | reversediff |             typed |   true |                391.8 |                 6.7 |

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (fb5413f) to head (7f4d023).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files          34       34           
  Lines        3815     3815           
=======================================
  Hits         3238     3238           
  Misses        577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 27, 2025

Pull Request Test Coverage Report for Build 14095924421

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.3%) to 81.639%

Files with Coverage Reduction New Missed Lines %
src/varinfo.jl 3 83.83%
Totals Coverage Status
Change from base Build 14024259529: -3.3%
Covered Lines: 3108
Relevant Lines: 3807

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 27, 2025

Pull Request Test Coverage Report for Build 14095924421

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 84.965%

Files with Coverage Reduction New Missed Lines %
src/varinfo.jl 3 83.83%
Totals Coverage Status
Change from base Build 14024259529: 0.0%
Covered Lines: 3238
Relevant Lines: 3811

💛 - Coveralls

github-actions bot and others added 2 commits March 28, 2025 00:20
…p existing compat) (#866)

Co-authored-by: CompatHelper Julia <[email protected]>
…p existing compat) (#865)

Co-authored-by: CompatHelper Julia <[email protected]>
@penelopeysm
Copy link
Member

Blocked by JuliaDiff/ReverseDiff.jl#271

@devmotion
Copy link
Member

I made a new release of ReverseDiff: JuliaRegistries/General#127921

@penelopeysm
Copy link
Member

Brilliant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants